Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing dependency in one case of gen_f90_targets #4736

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

jgfouca
Copy link
Member

@jgfouca jgfouca commented Jan 13, 2022

This bug was causing .F changes to not be reflected in rebuilds.

Fixes #4341

[BFB]

This bug was causing .F changes to not be reflected in rebuilds.

[BFB]
@jgfouca
Copy link
Member Author

jgfouca commented Jan 13, 2022

@worleyph , apologies for the slow response on #4341

Copy link
Contributor

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct. I also ran a before/after test on cori and both passed

./create_test SMS_D.T62_oQU120_ais20.MPAS_LISIO_TEST.cori-haswell_gnu -q debug --walltime 00:30:00

jgfouca added a commit that referenced this pull request Jan 19, 2022
Fix missing dependency in one case of gen_f90_targets

This bug was causing .F changes to not be reflected in rebuilds.

Fixes #4341

[BFB]

* jgfouca/fix_mpas_cmake_missing_dep:
  Fix missing dependency in one case of gen_f90_targets
@jgfouca jgfouca merged commit b396be8 into master Jan 20, 2022
@jgfouca jgfouca deleted the jgfouca/fix_mpas_cmake_missing_dep branch January 20, 2022 17:44
xylar added a commit to xylar/compass that referenced this pull request Feb 4, 2022
commit hash: 44814ae3ce06ec1d175fc03a6c4471f9d3fad274

This update includes the following MPAS-Ocean PRs:
* Corrected coupling of ice biogeochemistry for MARBL
  E3SM-Project/E3SM#4641
* GPU port of ocean vmix routine (non-bit-for-bit in compass)
  E3SM-Project/E3SM#4680
* Fix filename interval for 2 analysis member restarts
  E3SM-Project/E3SM#4687
* fix calculation of the ML-averaged Brunt-Vaisala frequency
  E3SM-Project/E3SM#4715
* Fix interface locations for 60-layer PHC grid
  E3SM-Project/E3SM#4729
* Update PGI compiler runs of E3SM on GPUs
  E3SM-Project/E3SM#4748
* Initialize Coriolis param in its own subroutine
  E3SM-Project/E3SM#4750
* Add mode specification to conservation check streams
  E3SM-Project/E3SM#4769

And the following MPAS framework PRS:
* add -ffpe-summary=none to stand-alone MPAS Makefile for gnu
  E3SM-Project/E3SM#4643
* Fix missing dependency in one case of gen_f90_targets
  E3SM-Project/E3SM#4736
* new reproducible global sum module for MPAS components
  E3SM-Project/E3SM#4700
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modifying files in mpas-framework is not recognized by ./case.build
2 participants