Fix filename interval for 2 analysis member restarts #4687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Eliassen-Palm and time-filters analysis members both had hard-coded restart file intervals of 1 year. This causes restarts with these analysis members to fail in situations where the restart interval does not match the file interval. This merge changes the filename interval to be the same as the output interval to match restart streams in all other analysis members.
|
These analysis members are not enabled in E3SM runs by default: So these changes will have no effect on E3SM runs. The only effect will be in |
|
@mark-petersen and @jonbob, please let me know what E3SM testing you would like to see from me on this PR. I'm happy to do whatever is needed but don't want to run arbitrary testing without checking with you first. |
mark-petersen
approved these changes
Dec 6, 2021
There was a problem hiding this comment.
Agreed. Thanks for fixing this @xylar. I did a quick check, and these are the only two:
cd components/mpas-ocean/src/analysis_members
grep -A 5 Restart *xml|grep filename_interval
Registry_conservation_check.xml- filename_interval="output_interval"
Registry_eliassen_palm.xml- filename_interval="01-00-00_00:00:00"
Registry_harmonic_analysis.xml- filename_interval="output_interval"
Registry_lagrangian_particle_tracking.xml- filename_interval="output_interval"
Registry_time_filters.xml- filename_interval="01-00-00_00:00:00"
Registry_time_series_stats_climatology.xml- filename_interval="output_interval"
Registry_time_series_stats_custom.xml- filename_interval="output_interval"
Registry_time_series_stats_daily.xml- filename_interval="output_interval"
Registry_time_series_stats_monthly_max.xml- filename_interval="output_interval"
Registry_time_series_stats_monthly_mean.xml- filename_interval="output_interval"
Registry_time_series_stats_monthly_min.xml- filename_interval="output_interval"
|
Thanks, @mark-petersen. I did the same search but much less efficiently. Glad we found the same thing. |
jonbob
added a commit
that referenced
this pull request
Dec 7, 2021
…tervals' into next (PR #4687) Fix filename interval for 2 analysis member restarts The Eliassen-Palm and time-filters analysis members both had hard-coded restart file intervals of 1 year. This causes restarts with these analysis members to fail in situations where the restart interval does not match the file interval. This merge changes the filename interval to be the same as the output interval to match restart streams in all other analysis members. [BFB]
|
passes sanity testing -- merged to next |
|
merged to master |
xylar
deleted the
ocean/fix-two-analysis-member-restart-filename-intervals
branch
xylar
added a commit
to xylar/compass
that referenced
this pull request
Dec 12, 2021
commit hash: 89d472679bba9e82671301d872bf128112c97d75 This update includes the following MPAS-Ocean PRs: * GPU port of ocean vmix routine (non-bit-for-bit in compass), E3SM-Project/E3SM#4680 * Fix filename interval for 2 analysis member restarts (bit-for-bit) E3SM-Project/E3SM#4687
xylar
added a commit
to xylar/compass
that referenced
this pull request
Feb 4, 2022
commit hash: 44814ae3ce06ec1d175fc03a6c4471f9d3fad274 This update includes the following MPAS-Ocean PRs: * Corrected coupling of ice biogeochemistry for MARBL E3SM-Project/E3SM#4641 * GPU port of ocean vmix routine (non-bit-for-bit in compass) E3SM-Project/E3SM#4680 * Fix filename interval for 2 analysis member restarts E3SM-Project/E3SM#4687 * fix calculation of the ML-averaged Brunt-Vaisala frequency E3SM-Project/E3SM#4715 * Fix interface locations for 60-layer PHC grid E3SM-Project/E3SM#4729 * Update PGI compiler runs of E3SM on GPUs E3SM-Project/E3SM#4748 * Initialize Coriolis param in its own subroutine E3SM-Project/E3SM#4750 * Add mode specification to conservation check streams E3SM-Project/E3SM#4769 And the following MPAS framework PRS: * add -ffpe-summary=none to stand-alone MPAS Makefile for gnu E3SM-Project/E3SM#4643 * Fix missing dependency in one case of gen_f90_targets E3SM-Project/E3SM#4736 * new reproducible global sum module for MPAS components E3SM-Project/E3SM#4700
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Eliassen-Palm and time-filters analysis members both had hard-coded restart file intervals of 1 year. This causes restarts with these analysis members to fail in situations where the restart interval does not match the file interval. This merge changes the filename interval to be the same as the output interval to match restart streams in all other analysis members.