i#6938 sched migrate: Remove duplicate option #7007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Windows jobs are all failing b/c the sourceforge doxyen link is dead. I will try to update the jobs separately. |
Hmm, the link looks valid, and |
edeiana
approved these changes
Sep 27, 2024
It works for me as well with I'm not sure if this happened before as well. Perhaps |
This was referenced Sep 27, 2024
derekbruening
added a commit
to DynamoRIO/drmemory
that referenced
this pull request
Sep 27, 2024
Switches from directly downloading from sourceforge, which was giving us 403 errors suddenly, to using https://github.com/ssciwr/doxygen-install. Updates jwlawson/actions-setup-cmake to v2. Issue: DynamoRIO/dynamorio#7007
derekbruening
added a commit
to DynamoRIO/drmemory
that referenced
this pull request
Sep 27, 2024
Switches from directly downloading from sourceforge, which was giving us 403 errors suddenly, to using https://github.com/ssciwr/doxygen-install. Updates jwlawson/actions-setup-cmake to v2. Issue: DynamoRIO/dynamorio#7007
derekbruening
added a commit
that referenced
this pull request
Sep 27, 2024
Switches from directly downloading from sourceforge, which was giving us 403 errors suddenly after 4 years of working, to use https://github.com/ssciwr/doxygen-install which presumably will handle the changing versions for us (which was the problem when we used to directly download the doxygen packages). The downside may be that we'll keep getting newer versions and have to handle periodic warnings/failures: but we'd hit that eventually anyway on other platforms and is something we have to do anyway to maintain everything. Also updates jwlawson/actions-setup-cmake from v1.8 to v2 as a problem was seen with that as well. Fixes #7007
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a duplicate option -sched_time_per_us which was accidentally added by PR #6980 separately from the similar -sched_time_units_per_us from PR #6985.
Issue: #6938