i#6938 sched migrate: All options in microseconds + single scale #6980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors the scheduler's time-oriented options to become based on
simulated microseconds rather than being unitless and having to all be
separately scaled depending on the simulator's clock.
Deprecates these scheduler_options_t fields, replacing them with new versions:
+ quantum_duration => quantum_duration_{instructions,us}
+ block_time_scale => block_time_multiplier
+ block_time_max => block_time_max_us
Adds a new "time_units_per_us" which is the single place where a
simulator sets the relationship between the value passed to "cur_time"
in next_record() and simulated microseconds. The aforementioned
fields are all compared to cur_time multiplied by time_units_per_us.
This is a prelude to adding yet more time-based options for the
forthcoming scheduler additions with migration thresholds and
rebalance periods.
Adds legacy support for binary compatibility. Recompiling will result
in error messages prompting an update to the new fields.
Adds a unit test of legacy support.
Issue: #6938
|
a64 failure is drcachesim.simple-config-file bundle assert #3320 |
brettcoon
approved these changes
Sep 16, 2024
derekbruening
added a commit
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the scheduler's time-oriented options to become based on simulated microseconds rather than being unitless and having to all be separately scaled depending on the simulator's clock.
Deprecates these scheduler_options_t fields, replacing them with new versions:
Adds a new "time_units_per_us" which is the single place where a simulator sets the relationship between the value passed to "cur_time" in next_record() and simulated microseconds. The aforementioned fields are all compared to cur_time multiplied by time_units_per_us.
This is a prelude to adding yet more time-based options for the forthcoming scheduler additions with migration thresholds and rebalance periods.
Adds legacy support for binary compatibility. Recompiling will result in error messages prompting an update to the new fields.
Adds a unit test of legacy support.
Issue: #6938