i#5725: Set consistent x86 vendor decoding default #6438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we initialize the proc_get_vendor() to VENDOR_UNKNOWN we get contradictory decoding results for x86 opcodes that vary between VENDOR_AMD and VENDOR_INTEL (because some of our decoding code checks one and some checks the other), so we pick one (VENDOR_INTEL) for a stable self-consistent default. Fixes #5725
abhinav92003
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we initialize the proc_get_vendor() to VENDOR_UNKNOWN we get contradictory decoding results for x86 opcodes that vary between VENDOR_AMD and VENDOR_INTEL (because some of our decoding code checks one and some checks the other), so we pick one (VENDOR_INTEL) for a stable self-consistent default. We set this statically and we override the underlying hardware in proc_init(). The user can use proc_set_vendor() (after an explicit init) to override if desired.
Fixes #5725