-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i#5538 memtrace seek, part 5: Add schedule index files #5713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds two new files generated by raw2trace, each containing 4-entry records of <tid, timestamp, cpuid, instr_count>. These are used to take a global or per-cpu target instruction count and determine the corresponding instruction count within each software thread, for seeking within each trace file. One file is globally sorted by timestamp, and the other is a zip file with a separate component for each cpuid holding entries sorted by timestamp for that cpu. Adds new invariant_checker tests for each file by passing them in for test_mode. The invariant_checker re-constructs the same sorted sequences using the trace data and confirms it matches the data in the files. This involves adding a new zipfile_stream_t interface for a simple continuous stream of each zipfile component in turn. Issue: #5538
…n-null empty sched file
…ction so subclasses can extend raw2trace_thread_data_t
…orithm header for some VS2019 builds; add sched file check exclusions for needs-raw2trace check
x64 failure is flaky api.detach_state assert about cache consistency #5123 |
bete0
reviewed
Nov 1, 2022
bete0
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two new files generated by raw2trace, each containing 4-entry records of <tid, timestamp, cpuid, instr_count>. These are used to take a global or per-cpu target instruction count and determine the corresponding instruction count within each software thread, for seeking within each trace file. One file is globally sorted by timestamp, and the other is a zip file with a separate component for each cpuid holding entries sorted by timestamp for that cpu.
Adds new invariant_checker tests for each file by passing them in for test_mode. The invariant_checker re-constructs the same sorted sequences using the trace data and confirms it matches the data in the files. This involves adding a new zipfile_stream_t interface for a simple continuous stream of each zipfile component in turn.
Issue: #5538