Skip to content

Commit

Permalink
i#5538 memtrace seek, part 6: Virtualize raw2trace_thread_data (#5715)
Browse files Browse the repository at this point in the history
Adds a missing piece from part 5 PR #5713 where raw2trace's
thread_data_ was indirected to support a subclass extending it.
However, its destructor was not virtual, which prevented such
extension.  We address that here.

Issue: #5538
  • Loading branch information
derekbruening authored Nov 3, 2022
1 parent 0aa768d commit e6694ac
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions clients/drcachesim/tracer/raw2trace.h
Original file line number Diff line number Diff line change
Expand Up @@ -1878,6 +1878,10 @@ class raw2trace_t : public trace_converter_t<raw2trace_t> {
, last_block_summary(nullptr)
{
}
// Support subclasses extending this struct.
virtual ~raw2trace_thread_data_t()
{
}

int index;
thread_id_t tid;
Expand Down

0 comments on commit e6694ac

Please sign in to comment.