i#5658 rseq drreg: Put native sequence by barrier #5664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes PR #5663 which fixed drreg restoration for drbbdup but broke it for non-drbbdup. bb->instr was NULL so the preinsert was an append, and the label as the last instruction moved the drreg restore point to after the native sequence! Here, we explicitly append to avoid confusion, and we move the native sequence to the point of the barrier instead of at the final app instr, which is where the registers are actually native. Tested on larger apps using rseq which reliably crashed without this fix. This fix also seems to fully fix drbbdup usage with drmemtrace for #2039. Issue: #5658, #2039
abhinav92003
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PR #5663 which fixed drreg restoration for drbbdup but broke it for non-drbbdup. bb->instr was NULL so the preinsert was an append, and the label as the last instruction moved the drreg restore point to after the native sequence!
Here, we explicitly append to avoid confusion, and we move the native sequence to the point of the barrier instead of at the final app instr, which is where the registers are actually native.
Tested on larger apps using rseq which reliably crashed without this fix. This fix also seems to fully fix drbbdup usage with drmemtrace for #2039.
Issue: #5658, #2039