Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i#2626: AArch64 v8.0 decode: Add SQSHL, SHL and SLI #5084

Merged
merged 4 commits into from
Sep 9, 2021
Merged

i#2626: AArch64 v8.0 decode: Add SQSHL, SHL and SLI #5084

merged 4 commits into from
Sep 9, 2021

Conversation

joshua-warburton
Copy link
Collaborator

This patch implements the instructions:
SQSHL <V><d>, <V><n>, #<shift>
SHL <Vd>.<T>, <Vn>.<T>, #<shift>
SLI <Vd>.<T>, <Vn>.<T>, #<shift>

To implement these instructions an additional
operand was necessary to allow a zero-indexed
shift. The appropriate encode tests for an
instruction using this immhb_0shf operand have
been added.

Issue: #2626

@joshua-warburton
i#2626: AArch64 v8.0 decode: Add SQSHL, SHL and SLI
f78210a 
This patch implements the instructions:
SQSHL <V><d>, <V><n>, #<shift>
SHL <Vd>.<T>, <Vn>.<T>, #<shift>
SLI <Vd>.<T>, <Vn>.<T>, #<shift>

To implement these instructions an additional
operand was necessary to allow a zero-indexed
shift. The appropriate encode tests for an
instruction using this immhb_0shf operand have
been added.

Issue: #2626
Change-Id: Ie03a8fcdc6cd2e4b40661957aac50b77ca2239ff
@joshua-warburton
Merge remote-tracking branch 'upstream/master' into i2626-add-0shf-sq…
b4eabb8 
…shl-sli-shl

Change-Id: I66d0e0648ba9d2d5a13c3081868350220b2d9cee
AssadHashmi
AssadHashmi requested changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@AssadHashmi AssadHashmi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of duplication/common functionality in the decode_opnd_immhb_ and encode_opnd_immhb_ functions. Can you factor this out into two functions (one for decode, other encode) and call those?

@joshua-warburton
reduce code duplication
4b986c2 
Change-Id: Idfe57bf8130dd8f10bb4e2b1d584ffb85793837c
@joshua-warburton
Copy link
Collaborator Author

There's a lot of duplication/common functionality in the decode_opnd_immhb_ and encode_opnd_immhb_ functions. Can you factor this out into one function and call that?

Done

@joshua-warburton
formatting
47e279e 
Change-Id: If58462d2a12ce0c53a880f9bf416133927545cc2
@joshua-warburton joshua-warburton merged commit a3e53a4 into master Sep 9, 2021
@joshua-warburton joshua-warburton deleted the i2626-add-0shf-sqshl-sli-shl branch September 9, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AssadHashmi AssadHashmi AssadHashmi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshua-warburton @AssadHashmi