i#2820 trace thread subset: reset callbacks at exit #2844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resets callback functions to empty at exit to better support re-attach. Unfortunately i#2175 still prevents extending the thread filter test to include re-attach. Issue: #2820
Carrotman42
requested changes
Feb 21, 2018
clients/drcachesim/tracer/tracer.cpp
Outdated
| memset(&file_ops_func, 0, sizeof(file_ops_func)); | ||
| if (!offline_instru_t::custom_module_data(nullptr, nullptr, nullptr)) | ||
| DR_ASSERT(false && "failed to clear custom module callbacks"); | ||
| should_trace_thread_cb = nullptr; |
There was a problem hiding this comment.
What about thread_filtering_enabled, and trace_thread_cb_user_data just in case?
There was a problem hiding this comment.
Agreed, this is a heavyweight client and a few stores won't matter. Done.
Instate 4 re-attach iters in the burst_threads and burst_thread*filter tests. Add "firstglob" support to runmulti to post-process only one of the 4 re-attach traces to keep the tests simpler and faster. Add testing of the thread filter callback being reset across re-attach by passing in a specific user param. Issue: #2175, #2820
|
@Carrotman42, PTAL: tests should go green (took a bit of work; had to fix #2845 too). |
|
LGTM |
Carrotman42
approved these changes
Feb 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resets callback functions to empty at exit to better support re-attach.
Unfortunately i#2175 still prevents extending the thread filter test to
include re-attach.
Issue: #2820