Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nudge_test failed with an extra "done" on appveyor #2845

Closed
derekbruening opened this issue Feb 21, 2018 · 1 comment
Closed

nudge_test failed with an extra "done" on appveyor #2845

derekbruening opened this issue Feb 21, 2018 · 1 comment

Comments

@derekbruening
Copy link
Contributor

My newly-enabled-on-Windows test from i#1309 just failed with an extra
"done" being printed -- but why??

https://ci.appveyor.com/project/DynamoRIO/dynamorio/build/1.0.1697

[00:05:49] 131/246 Test #125: code_api|client.nudge_test ...................................***Failed  Required regular expression not found.Regex=[^thank you for testing the client interface
[00:05:49] ?
[00:05:49] nudge delivered 10
[00:05:49] ?
[00:05:49] nudge delivered 11
[00:05:49] ?
[00:05:49] done
[00:05:49] ?
[00:05:49] $
[00:05:49] ]  2.47 sec
[00:05:49] thank you for testing the client interface
[00:05:49] nudge delivered 10
[00:05:49] nudge delivered 11
[00:05:49] done
[00:05:49] done
derekbruening added a commit that referenced this issue Feb 21, 2018
Fixes the nudge_test output to not have two "done" message that result in a
race in runall.cmake.

Issue: #1309
Fixes #2845
@derekbruening
Copy link
Contributor Author

=> both infloop and the nudge_test client were printing "done.
runall.cmake saw the first one and then read the whole file.
There's a race as to whether it read in the 2nd one or not.

@derekbruening derekbruening self-assigned this Feb 21, 2018
derekbruening added a commit that referenced this issue Feb 22, 2018
Fixes the nudge_test output to not have two "done" message that result in a
race in runall.cmake.

Issue: #1309
Fixes #2845
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant