Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/notification mark as read #40

Merged
merged 4 commits into from
Jul 17, 2023

Conversation

Enzo707
Copy link
Contributor

@Enzo707 Enzo707 commented Jul 17, 2023

This PR implements:

  • fix for notifications "mark as read" feature
  • upgrade the notifications-panel version we use in NotificationCenter to 0.0.8
  • change NotificationsCenter version to 0.0.25

Ref.: DynamoDS/hig#7

FYI
@QilongTang

@Enzo707 Enzo707 force-pushed the Fix/Notification-MarkAsRead branch from 3bd8cb5 to cfb4fbf Compare July 17, 2023 22:52
@QilongTang QilongTang merged commit cfe7dae into DynamoDS:master Jul 17, 2023
avidit added a commit to avidit/NotificationCenter that referenced this pull request Sep 21, 2023
commit cfe7dae
Author: Enzo Batista <[email protected]>
Date:   Mon Jul 17 20:21:21 2023 -0300

    Fix/notification mark as read (DynamoDS#40)

    * refactor: Notifications MarkAsRead function

    * fix: notifications markAsRead

    * chore: update notifications-center and notifications-panel version

    * chore: re-generate package-lock

commit 75fc8e6
Author: Enzo Batista <[email protected]>
Date:   Thu Jun 8 21:12:41 2023 -0300

    chore: update notifications-panel and notifications-center version (DynamoDS#38)

commit 2219386
Author: Enzo Batista <[email protected]>
Date:   Thu Jun 1 14:13:56 2023 -0300

    chore:update-notifications-panel-version-to-0.0.4 (DynamoDS#37)

    * chore(package.json):update-notifications-panel-version-to-0.0.4

    * chore(package-lock.json):update-notifications-panel-version-to-0.0.4

    * feat: update version

commit fe9d579
Merge: 7ec7cad b445ab2
Author: reddyashish <[email protected]>
Date:   Wed May 31 13:34:11 2023 -0400

    Merge pull request DynamoDS#36 from Enzo707/feature/DYN-5296-notification-center-with-dynamic-height

    Feature/DYN 5296 notification center with dynamic height

commit b445ab2
Author: Enzo Batista <[email protected]>
Date:   Mon May 22 16:19:55 2023 -0300

    feat:implements-custom-hook-to-force-component-re-render

commit ab0250b
Author: Enzo Batista <[email protected]>
Date:   Mon May 22 01:05:39 2023 -0300

    feat:add-mechanism-to-send-notification-popup-height-to-dynamo

commit 675cb8f
Author: Enzo Batista <[email protected]>
Date:   Mon May 22 01:00:00 2023 -0300

    feat:add-empty-state-svg

commit 33c61ea
Author: Enzo Batista <[email protected]>
Date:   Wed May 17 12:30:53 2023 -0300

    popup-dynamic-height-working

commit 7ec7cad
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Mar 15 06:55:49 2023 -0700

    Bump webpack from 5.74.0 to 5.76.0 (DynamoDS#35)

    Bumps [webpack](https://github.com/webpack/webpack) from 5.74.0 to 5.76.0.
    - [Release notes](https://github.com/webpack/webpack/releases)
    - [Commits](webpack/webpack@v5.74.0...v5.76.0)

    ---
    updated-dependencies:
    - dependency-name: webpack
      dependency-type: direct:development
    ...

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit bb6f14b
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Feb 9 09:33:36 2023 -0500

    Bump @sideway/formula from 3.0.0 to 3.0.1 (DynamoDS#34)

    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 60aa47b
Merge: b8dbcb6 bd96611
Author: Ashish Aggarwal <[email protected]>
Date:   Thu Jan 26 13:38:32 2023 -0500

    Merge pull request DynamoDS#33 from filipeotero/DYN-5227-ArtifaktElement-FontStyle

    DYN-5227-NotificationCenter-Font

commit bd96611
Author: filipeotero <[email protected]>
Date:   Fri Jan 20 16:53:15 2023 -0300

    importing Artifakt font style

commit b8dbcb6
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Jan 9 21:10:18 2023 +0800

    Bump json5 from 2.2.1 to 2.2.3 (DynamoDS#32)

    Bumps [json5](https://github.com/json5/json5) from 2.2.1 to 2.2.3.
    - [Release notes](https://github.com/json5/json5/releases)
    - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
    - [Commits](json5/json5@v2.2.1...v2.2.3)

    ---
    updated-dependencies:
    - dependency-name: json5
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <[email protected]>

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 6b79da0
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Fri Nov 18 00:51:25 2022 -0500

    Bump loader-utils from 2.0.3 to 2.0.4 (DynamoDS#31)

    Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.3 to 2.0.4.
    - [Release notes](https://github.com/webpack/loader-utils/releases)
    - [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.4/CHANGELOG.md)
    - [Commits](webpack/loader-utils@v2.0.3...v2.0.4)

    ---
    updated-dependencies:
    - dependency-name: loader-utils
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <[email protected]>

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants