Feature/DYN 5296 notification center with dynamic height #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Enzo707
force-pushed
the
feature/DYN-5296-notification-center-with-dynamic-height
branch
from
d2a8d9a to
24c2603
Compare
|
@Enzo707 One test failure, please check PR build check |
Enzo707
force-pushed
the
feature/DYN-5296-notification-center-with-dynamic-height
branch
from
24c2603 to
ace10a1
Compare
|
@QilongTang @reddyashish please review this. Thanks |
reddyashish
reviewed
May 26, 2023
tests/e2e/e2e.test.js
Outdated
| const header = await page.waitForSelector('#root > div > div > header'); | ||
| await expect(header).toMatch('Notifications'); | ||
| }); | ||
| // it('should have correct header', async () => { |
There was a problem hiding this comment.
Add a todo comment on why we are commenting this failing test. Otherwise, we can just remove it.
There was a problem hiding this comment.
Sure, I'll remove it!
reddyashish
reviewed
May 26, 2023
| @@ -0,0 +1 @@ | |||
| export { default as EmptyStateArchiver } from './EmptyStateArchiver'; | |||
There was a problem hiding this comment.
sorry i might have missed but why do we need EmptyStateArchiver? Is that referenced from somewhere?
There was a problem hiding this comment.
This is just a good practice, it's recommended always have an index file that contains all the exports. So then, we could import components from the main folder. In this particular case imagine that we add more icons, we could use named imports from /icons instead of adding multiple ones.
This:
import { EmptyStateArchiver, Icon2, Icon3... } from './icons';
Instead of:
import EmptyStateArchiver from './icons/EmptyStateArchiver';
import Icon2 from './icons/icon2';
import ...
Enzo707
force-pushed
the
feature/DYN-5296-notification-center-with-dynamic-height
branch
from
ace10a1 to
b445ab2
Compare
reddyashish
approved these changes
May 31, 2023
avidit
added a commit
to avidit/NotificationCenter
that referenced
this pull request
Sep 21, 2023
commit cfe7dae Author: Enzo Batista <[email protected]> Date: Mon Jul 17 20:21:21 2023 -0300 Fix/notification mark as read (DynamoDS#40) * refactor: Notifications MarkAsRead function * fix: notifications markAsRead * chore: update notifications-center and notifications-panel version * chore: re-generate package-lock commit 75fc8e6 Author: Enzo Batista <[email protected]> Date: Thu Jun 8 21:12:41 2023 -0300 chore: update notifications-panel and notifications-center version (DynamoDS#38) commit 2219386 Author: Enzo Batista <[email protected]> Date: Thu Jun 1 14:13:56 2023 -0300 chore:update-notifications-panel-version-to-0.0.4 (DynamoDS#37) * chore(package.json):update-notifications-panel-version-to-0.0.4 * chore(package-lock.json):update-notifications-panel-version-to-0.0.4 * feat: update version commit fe9d579 Merge: 7ec7cad b445ab2 Author: reddyashish <[email protected]> Date: Wed May 31 13:34:11 2023 -0400 Merge pull request DynamoDS#36 from Enzo707/feature/DYN-5296-notification-center-with-dynamic-height Feature/DYN 5296 notification center with dynamic height commit b445ab2 Author: Enzo Batista <[email protected]> Date: Mon May 22 16:19:55 2023 -0300 feat:implements-custom-hook-to-force-component-re-render commit ab0250b Author: Enzo Batista <[email protected]> Date: Mon May 22 01:05:39 2023 -0300 feat:add-mechanism-to-send-notification-popup-height-to-dynamo commit 675cb8f Author: Enzo Batista <[email protected]> Date: Mon May 22 01:00:00 2023 -0300 feat:add-empty-state-svg commit 33c61ea Author: Enzo Batista <[email protected]> Date: Wed May 17 12:30:53 2023 -0300 popup-dynamic-height-working commit 7ec7cad Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Mar 15 06:55:49 2023 -0700 Bump webpack from 5.74.0 to 5.76.0 (DynamoDS#35) Bumps [webpack](https://github.com/webpack/webpack) from 5.74.0 to 5.76.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.74.0...v5.76.0) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit bb6f14b Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Feb 9 09:33:36 2023 -0500 Bump @sideway/formula from 3.0.0 to 3.0.1 (DynamoDS#34) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 60aa47b Merge: b8dbcb6 bd96611 Author: Ashish Aggarwal <[email protected]> Date: Thu Jan 26 13:38:32 2023 -0500 Merge pull request DynamoDS#33 from filipeotero/DYN-5227-ArtifaktElement-FontStyle DYN-5227-NotificationCenter-Font commit bd96611 Author: filipeotero <[email protected]> Date: Fri Jan 20 16:53:15 2023 -0300 importing Artifakt font style commit b8dbcb6 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Jan 9 21:10:18 2023 +0800 Bump json5 from 2.2.1 to 2.2.3 (DynamoDS#32) Bumps [json5](https://github.com/json5/json5) from 2.2.1 to 2.2.3. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v2.2.1...v2.2.3) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 6b79da0 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri Nov 18 00:51:25 2022 -0500 Bump loader-utils from 2.0.3 to 2.0.4 (DynamoDS#31) Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.3 to 2.0.4. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v2.0.4/CHANGELOG.md) - [Commits](webpack/loader-utils@v2.0.3...v2.0.4) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Implements a mechanism to send any change related to notification center height to Dynamo so then we could trigger the notification popup resizing.