DYN-6259 #2972
DYN-6259 #2972
Conversation
|
So this is reverting #2933? |
yes |
| @@ -607,8 +607,7 @@ private static RevitDynamoModel InitializeCoreModel(DynamoRevitCommandData comma | |||
| AuthProvider = new RevitOAuth2Provider(new DispatcherSynchronizationContext(Dispatcher.CurrentDispatcher)), | |||
| ExternalCommandData = commandData, | |||
| UpdateManager = revitUpdateManager, | |||
| ProcessMode = isAutomationMode ? TaskProcessMode.Synchronous : TaskProcessMode.Asynchronous, | |||
| Preferences = PreferenceSettings.Instance | |||
There was a problem hiding this comment.
Does removing this not bring back other issues with Preferences on Dynamo Revit startup?
There was a problem hiding this comment.
Does removing this not bring back other issues with Preferences on Dynamo Revit startup?
No because we are returning the responsibility of management/creation of the preferences to the DynamoModel here DynamoDS/Dynamo#14427, we need both to make them work properly.
There was a problem hiding this comment.
This is reverting the code back to https://github.com/DynamoDS/DynamoRevit/blob/RC2.18.1_Revit2024.1/src/DynamoRevit/DynamoRevit.cs#L476. I think it was our mistake that these changes were not needed in the first place
|
If testing passes, can we make sure to also merge in branches |
|
@jesusalvino Would you initiate the cherry-pick? |
Co-authored-by: Jesus Alfredo Alviño <[email protected]>
Co-authored-by: Jesus Alfredo Alviño <[email protected]>
Done: |
Co-authored-by: Jesus Alfredo Alviño <[email protected]>
Co-authored-by: Jesus Alfredo Alviño <[email protected]>
Purpose
Fixing the bug https://jira.autodesk.com/browse/DYN-6259 excluding passing the Preferences due to it will be handled in the DynamoModel side based on the PathManager info. Follow up PR of DynamoDS/Dynamo#14427
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
@reddyashish