Pass the Preferences as part of the Initializacion configuration #2933
Conversation
| @@ -607,7 +607,8 @@ private static RevitDynamoModel InitializeCoreModel(DynamoRevitCommandData comma | |||
| AuthProvider = new RevitOAuth2Provider(new DispatcherSynchronizationContext(Dispatcher.CurrentDispatcher)), | |||
| ExternalCommandData = commandData, | |||
| UpdateManager = revitUpdateManager, | |||
| ProcessMode = isAutomationMode ? TaskProcessMode.Synchronous : TaskProcessMode.Asynchronous | |||
| ProcessMode = isAutomationMode ? TaskProcessMode.Synchronous : TaskProcessMode.Asynchronous, | |||
| Preferences = PreferenceSettings.Instance | |||
There was a problem hiding this comment.
Do we need to pass the PathResolver?
There was a problem hiding this comment.
Do we need to pass the PathResolver?
yes as the previously been doing in the startconfiguration, now We assigning it to the PathManager in the DynamoModel ctor, the only update is need to pass the Preferences.
|
@Mikhinja PTAL, please refer to DynamoDS/Dynamo#14118 |
|
hi @Mikhinja This is a pairing change to work with the RC2.19.0 build |
|
Does this cause the multiple instance bug shown on slack? |
| @@ -276,7 +276,8 @@ protected override void StartDynamo(TestSessionConfiguration testConfig) | |||
| SchedulerThread = new TestSchedulerThread(), | |||
| PackageManagerAddress = "https://www.dynamopackages.com", | |||
| ExternalCommandData = commandData, | |||
| ProcessMode = RevitTaskProcessMode | |||
| ProcessMode = RevitTaskProcessMode, | |||
| Preferences = PreferenceSettings.Instance | |||
There was a problem hiding this comment.
have you tried running all RTF tests locally?
There was a problem hiding this comment.
have you tried running all RTF tests locally?
I have tried but even when I put the paths and the proper tests it got me errors, I have tested with some Dynamo flows under the DynamoRevit pointing to DynamoCore 4.8
I Don't think so since I have tested a branch before this change, but looks like it's an issue that only pass for my local setup |
Co-authored-by: Jesus Alfredo Alviño <[email protected]>
Purpose
As part of the task https://jira.autodesk.com/browse/DYN-5816 the DynamoModel that the class RevitDynamoModel inherits, needs to pass the explicit Preferences as part of its initialization configuration.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
@reddyashish