Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-1999 Adding a section for users to provide feedback. #9822

Merged
merged 7 commits into from
Jul 2, 2019
Merged

DYN-1999 Adding a section for users to provide feedback. #9822

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7a91f48
DYN-1999 Adding a section for users to provide feedback.
reddyashish Jul 1, 2019
5bf585c
Removing extra styling
reddyashish Jul 1, 2019
c151abb
Extra spacing
reddyashish Jul 1, 2019
7272baf
Addressing comments
reddyashish Jul 1, 2019
e0e086d
Addressing comments
reddyashish Jul 1, 2019
0a0827d
Setting grid row value to zero.
reddyashish Jul 2, 2019
4db5920
Changing background color
reddyashish Jul 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions src/DynamoCoreWpf/Properties/Resources.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions src/DynamoCoreWpf/Properties/Resources.en-US.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2199,4 +2199,13 @@ Do you want to install the latest Dynamo update?</value>
<data name="ExtensionAlreadyPresent" xml:space="preserve">
<value>No new tab is added, as the extension is already present in the extensions side bar.</value>
</data>
<data name="ProvideFeedbackButton" xml:space="preserve">
<value> Provide Feedback</value>
</data>
<data name="PreviewText" xml:space="preserve">
<value> This Feature is in Preview! </value>
</data>
<data name="ProvideFeedbackError" xml:space="preserve">
<value>Could not re-direct to the Dynamo forum page for feedback:</value>
</data>
</root>
9 changes: 9 additions & 0 deletions src/DynamoCoreWpf/Properties/Resources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2202,4 +2202,13 @@ Want to publish a different package?</value>
<data name="ExtensionAlreadyPresent" xml:space="preserve">
<value>No new tab is added, as the extension is already present in the extensions side bar.</value>
</data>
<data name="ProvideFeedbackButton" xml:space="preserve">
<value> Provide Feedback</value>
</data>
<data name="PreviewText" xml:space="preserve">
<value> This Feature is in Preview! </value>
</data>
<data name="ProvideFeedbackError" xml:space="preserve">
<value>Could not re-direct to the Dynamo forum page for feedback:</value>
</data>
</root>
3 changes: 2 additions & 1 deletion src/DynamoCoreWpf/UI/Themes/Modern/DynamoColorsAndBrushes.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,9 @@
<Color x:Key="SelectionColor">#009EFF</Color>
<Color x:Key="MaterialColor">#efede4</Color>

<!--Sidebar-->
<!--Extensions Sidebar-->
<SolidColorBrush x:Key="BorderBrushWhite" Color="#FF3F4040" />
<SolidColorBrush x:Key="FeedbackSectionBackground" Color="CornflowerBlue" />

<!-- Library background-->
<SolidColorBrush x:Key="SearchTextBoxBackground" Color="#F1F2F2" />
Expand Down
6 changes: 3 additions & 3 deletions src/DynamoCoreWpf/Views/Core/DynamoView.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1677,7 +1677,7 @@
Grid.Row="2"
Grid.Column="4"
Grid.RowSpan="2">
<TabControl Name="tabDynamic" ItemsSource="{Binding}">
<TabControl Name="tabDynamic" Background="#353535" BorderThickness="0" ItemsSource="{Binding}">
QilongTang marked this conversation as resolved.
Show resolved Hide resolved
<TabControl.Resources>
<!--Styling for the close button in the tab-->
<Style TargetType="{x:Type Button}"
Expand Down Expand Up @@ -1711,7 +1711,7 @@
</Setter>
</Style>

<!--Template for each tab item in the extensions side bar-->
<!--Template for tab header in the extensions side bar-->
<DataTemplate x:Key="TabHeader" DataType="TabItem">
<DockPanel HorizontalAlignment="Stretch" MinWidth="{Binding Source={x:Static configuration:Configurations.ExtensionsSideBarTabMinWidth}}">
<TextBlock Text="{Binding RelativeSource={RelativeSource AncestorType={x:Type TabItem}}, Path=Header}" HorizontalAlignment="Stretch"/>
Expand Down Expand Up @@ -1862,7 +1862,7 @@
Grid.Row="2"
Grid.RowSpan="2"
Height="Auto"
Width="3"
Width="0"
QilongTang marked this conversation as resolved.
Show resolved Hide resolved
Name="extensionSplitter"
HorizontalAlignment="Stretch"
VerticalAlignment="Stretch"
Expand Down
59 changes: 57 additions & 2 deletions src/PackageDependencyViewExtension/PackageDependencyView.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,19 @@
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
xmlns:p="clr-namespace:Dynamo.Wpf.Properties;assembly=DynamoCoreWpf"
xmlns:ui="clr-namespace:Dynamo.UI;assembly=DynamoCoreWpf"
mc:Ignorable="d"
VerticalAlignment="Top"
HorizontalAlignment="Left">
<Grid Background= "#353535" Height="800">
<UserControl.Resources>
<ResourceDictionary>
<ResourceDictionary.MergedDictionaries>
<ui:SharedResourceDictionary Source="{x:Static ui:SharedDictionaryManager.DynamoColorsAndBrushesDictionaryUri}" />
</ResourceDictionary.MergedDictionaries>
</ResourceDictionary>
</UserControl.Resources>
<Grid Background= "#353535" Height="860">
<Grid.RowDefinitions>
<RowDefinition Height="Auto"/>
<RowDefinition Height="Auto"/>
Expand All @@ -26,7 +35,7 @@
RowBackground="Transparent"
FontSize="14"
IsHitTestVisible="False"
Grid.Row="0">
Grid.Row="1">
reddyashish marked this conversation as resolved.
Show resolved Hide resolved
<DataGrid.Columns>
<DataGridTemplateColumn>
<DataGridTemplateColumn.HeaderTemplate>
Expand Down Expand Up @@ -86,5 +95,51 @@
</TextBlock>
</Button>
</Grid>-->

<!-- Template for the feedback banner -->
<DockPanel Name="Feedback" Margin="0,800,0,40" Grid.Row="1">
QilongTang marked this conversation as resolved.
Show resolved Hide resolved
<StatusBar Background="{StaticResource FeedbackSectionBackground}" DockPanel.Dock="Bottom" Height="55">
<!-- Preview text -->
<StatusBarItem>
<Border Height="50">
<TextBlock TextWrapping="Wrap" Padding="10,0,10,0" FontSize="15" Foreground="White" Text="{x:Static p:Resources.PreviewText}" VerticalAlignment="Center"/>
</Border>
</StatusBarItem>
<StatusBarItem Width="193" Margin="100,0,0,0" Height="40">
<Border Name="FeedbackBorder" BorderThickness="1">
<Border.Style>
<Style>
<Style.Triggers>
<Trigger Property="Border.IsMouseOver" Value="True">
<Setter Property="Border.BorderBrush" Value="White" />
</Trigger>
<Trigger Property="Border.IsMouseOver" Value="False">
<Setter Property="Border.BorderBrush" Value="#373737" />
</Trigger>
</Style.Triggers>
</Style>
</Border.Style>
<!-- Feedback button -->
<Button HorizontalAlignment="Right"
Width="150" Click="ProvideFeedback" Background="#373737" Height="30">
<TextBlock TextWrapping="Wrap" FontSize="15" Foreground="White" Height="20" Text="{x:Static p:Resources.ProvideFeedbackButton}" VerticalAlignment="Center"/>
<Button.Style>
<Style TargetType="{x:Type Button}">
<Setter Property="Template">
<Setter.Value>
<ControlTemplate TargetType="{x:Type Button}">
<Border Background="{TemplateBinding Background}">
<ContentPresenter HorizontalAlignment="Center" VerticalAlignment="Center"/>
</Border>
</ControlTemplate>
</Setter.Value>
</Setter>
</Style>
</Button.Style>
</Button>
</Border>
</StatusBarItem>
</StatusBar>
</DockPanel>
</Grid>
</UserControl>
16 changes: 16 additions & 0 deletions src/PackageDependencyViewExtension/PackageDependencyView.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
using System;
using System.Collections.ObjectModel;
using System.ComponentModel;
using System.Windows;
using System.Windows.Controls;
using System.Windows.Media;

Expand All @@ -17,6 +18,8 @@ public partial class PackageDependencyView : UserControl

private WorkspaceModel currentWorkspace;

private String FeedbackLink = "https://forum.dynamobim.com/t/call-for-feedback-on-dynamo-graph-package-dependency-display/37229";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reddyashish I think this should just be:
https://github.com/DynamoDS/Dynamo/issues in general - @QilongTang what do you think? I think your forum post is auto closing in a few days?

Copy link
Contributor

@QilongTang QilongTang Jul 1, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the auto closing last night. Also I think 3rd party extension owner ship wise I would prefer forum post if you would like to set an example. I understand that because our team owns this, this should lives in Dynamo issues, maybe we could message that differently


private ViewLoadedParams loadedParams;
private PackageDependencyViewExtension dependencyViewExtension;

Expand All @@ -38,6 +41,19 @@ private Boolean HasMissingPackage
}
}

/// <summary>
/// Re-directs to a web link to get the feedback from the user.
/// </summary>
private void ProvideFeedback(object sender, EventArgs e)
{
try {
System.Diagnostics.Process.Start(FeedbackLink);
}
catch (Exception ex) {
String message = Dynamo.Wpf.Properties.Resources.ProvideFeedbackError + "\n\n" + ex.Message;
MessageBox.Show(message, "Error", MessageBoxButton.OK, MessageBoxImage.Error);
}
}

/// <summary>
/// Event handler for workspaceAdded event
Expand Down