Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-1999 Adding a section for users to provide feedback. #9822

Merged
merged 7 commits into from
Jul 2, 2019

Conversation

reddyashish
Copy link
Contributor

@reddyashish reddyashish commented Jul 1, 2019

Purpose

This PR is to add a footer section to get feedback from the user regarding the package dependency view extension feature.

JIRA: https://jira.autodesk.com/browse/DYN-1999

The LightBlue color for the section was making it hard to read the text inside, so I used another shade of blue. Let me know your thoughts on these.

1

2

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@DynamoDS/dynamo

@QilongTang
Copy link
Contributor

One comment then LGTM. Also can we get rid of the white board around extension view in the right panel? Looking a bit strange and inconsistent with the left one

@@ -17,6 +17,8 @@ public partial class PackageDependencyView : UserControl

private WorkspaceModel currentWorkspace;

private String FeedbackLink = "https://forum.dynamobim.com/t/call-for-feedback-on-dynamo-graph-package-dependency-display/37229";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reddyashish I think this should just be:
https://github.com/DynamoDS/Dynamo/issues in general - @QilongTang what do you think? I think your forum post is auto closing in a few days?

Copy link
Contributor

@QilongTang QilongTang Jul 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the auto closing last night. Also I think 3rd party extension owner ship wise I would prefer forum post if you would like to set an example. I understand that because our team owns this, this should lives in Dynamo issues, maybe we could message that differently

@mjkkirschner
Copy link
Member

@Amoursol FYI

Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments then Good for me

Adding to resource and configuration files.
@reddyashish
Copy link
Contributor Author

@Amoursol Is the background color fine?

@Amoursol
Copy link
Contributor

Amoursol commented Jul 2, 2019

@reddyashish We should be very careful of introducing another colour to the Dynamo Palette without good reason. Can we try black text on the original blue please?

@reddyashish
Copy link
Contributor Author

After talking to Sol, since we have all the text in dynamo in White color, we wanted to keep that consistent. For the background color, we are using the same color that appears on the border of a node when it is selected in the workspace.

Capture

@reddyashish
Copy link
Contributor Author

Addressed all the comments. If this looks good, we can merge it.

@QilongTang QilongTang added the LGTM Looks good to me label Jul 2, 2019
@reddyashish
Copy link
Contributor Author

Merging this. Will cherry-pick this to 2.3 also

@reddyashish reddyashish merged commit 8202644 into DynamoDS:master Jul 2, 2019
reddyashish added a commit to reddyashish/Dynamo that referenced this pull request Jul 2, 2019
* DYN-1999 Adding a section for users to provide feedback.

* Removing extra styling

* Extra spacing

* Addressing comments

* Addressing comments

Adding to resource and configuration files.

* Setting grid row value to zero.

* Changing background color

(cherry picked from commit 8202644)
reddyashish added a commit that referenced this pull request Jul 2, 2019
* DYN-1999 Adding a section for users to provide feedback.

* Removing extra styling

* Extra spacing

* Addressing comments

* Addressing comments

Adding to resource and configuration files.

* Setting grid row value to zero.

* Changing background color

(cherry picked from commit 8202644)
mjkkirschner pushed a commit that referenced this pull request Aug 3, 2019
* DYN-1999 Adding a section for users to provide feedback.

* Removing extra styling

* Extra spacing

* Addressing comments

* Addressing comments

Adding to resource and configuration files.

* Setting grid row value to zero.

* Changing background color
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants