Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7946: DYN-7965 [Cherry-Pick] #15705

Merged
merged 4 commits into from
Dec 5, 2024
Merged

7946: DYN-7965 [Cherry-Pick] #15705

merged 4 commits into from
Dec 5, 2024

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Dec 5, 2024

Purpose

Follow up of #15704, Cherry-picking

DYN-7946

DYN-7945

DYN-7889

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

N/A

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@github-actions github-actions bot changed the title DYN-7965 [Cherry-Pick] 7946: DYN-7965 [Cherry-Pick] Dec 5, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7946

@QilongTang QilongTang added this to the 3.4.1 milestone Dec 5, 2024
Copy link

github-actions bot commented Dec 5, 2024

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

Copy link
Contributor

@RobertGlobant20 RobertGlobant20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QilongTang QilongTang merged commit 80b1654 into RC3.4.1_master Dec 5, 2024
26 of 27 checks passed
@QilongTang QilongTang deleted the CherryPick branch December 5, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants