Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-7889: Improve parsing and compatibility of user-provided dynamo/host versions #15682

Merged

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Nov 21, 2024

Purpose

This is a hot-fix to address the discrepancy between internal dynamo / host versions (which are fully formed, eg. "2.1.19.2145") and the compatibility versions provided by users (partly formed, eg. "2.1.19" or even "2").

  • now equates: "2" == "2.0" == "2.0.0"
  • handles single versions
  • handles min/max versions

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • there was a mismatch between fully-formed "2.1.9.2150" Dynamo/Host versions, and the incoming build/major/minor versions

Reviewers

@zeusongit
@QilongTang

FYIs

@jnealb

…lity matrix versions

- there was a mismatch between fully-formed "2.1.9.2150" Dynamo/Host versions, and the incoming build/major/minor versions
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7889

@QilongTang QilongTang added this to the 3.5 milestone Nov 21, 2024
@dnenov dnenov changed the title DYN-7889:incompatible internal dynamo version vs incoming comp versions DYN-7889: Improve parsing and compatibility of user-provided dynamo/host versions Nov 21, 2024
Copy link

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@QilongTang QilongTang merged commit 550354c into DynamoDS:master Nov 22, 2024
27 checks passed
QilongTang pushed a commit that referenced this pull request Dec 5, 2024
@QilongTang QilongTang mentioned this pull request Dec 5, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants