7343: DYN-7341: Pm searchresults compatibilityfilter #15568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added compatibility filters - no tests yet, functionality not tested yet (still waiting for actual compatibility response to come through)
- picking changes from old branch
UI Smoke TestsTest: success. 11 passed, 0 failed. |
dnenov
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7341
github-actions
bot
changed the title
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7343
|
Does searching on a filtered list preserve the filter? |
|
Can we add some tests? |
QilongTang
reviewed
Oct 30, 2024
src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerSearchViewModel.cs
Show resolved
Hide resolved
QilongTang
approved these changes
Oct 30, 2024
…compatibilityfilter
It does! I uploaded a gif showing this behavior. |
- added test for the new filter type - unsubscribing from propertyChanged in Dispose() - small refactor to match style
Done! And I think all other comments are addressed at this point @zeusongit ! |
reddyashish
approved these changes
Oct 30, 2024
dnenov
changed the title
|
|
github-actions
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Follow up to Search PM Redesign PR. Adding
compatibility filters. Addressing this Jira ticket As a Dynamo package consumer, I want to filter packages based on compatibility infoChanges
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Compatibilitybit of workcompatible,unknown compatibility,incompatibleReviewers
@QilongTang
@zeusongit
@achintyabhat
FYIs
@reddyashish