DYN-7341: PM redesign search tab with compatibility info #15522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- initial UI changes - blocker reached - not sure where the host compatibility information is coming from
- now uses listview with expanding items instead of a datagrid
- finished the ui elements as per the design - starting transitions
- version is compatible changes icon
- main ui changes are done - add back the package dependencies links (should be working in the current live version)
- merged specific files from commit
- picking specific files only
- replaced the mockup data with the real Greg response - adapted the solution, but will work on simplifying it further
- added public properties to the declared API doc
UI Smoke TestsTest: success. 11 passed, 0 failed. |
- visibility when no version compatibility infos are found - removed table interactions
- simplified the way to instantiate the information feeding the compatibility table - now directly and dynamically takes that from the compatibility_matrx response - test added
- added test for latest compatible version
- will set the detail version expander corresponding to the currently selected package version to expanded upon opening the package details view - changed invoking of the scroll up to happen after the view has finished generating to make sure it scrolls all the way to the top
- added tooltips and related resources - added fallback message to compatibility section inside detail items if no compatibility is found
- properly centers the messagebox in Dynamo/Package Manager window
QilongTang
reviewed
Oct 4, 2024
src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerClientViewModel.cs
Outdated
Show resolved
Hide resolved
- added a temporary compatibilityMap in lieu of the route to come - added tests to complement the complex compatibility computation
- captured a large portion of tests failing after adding a new message box prompt
|
In the GIF when installing a package with unknown compatibility, the message shown is for incompatibility. |
|
Also @dnenov there is one conflict, resolve it. |
reddyashish
reviewed
Oct 16, 2024
reddyashish
reviewed
Oct 16, 2024
reddyashish
reviewed
Oct 16, 2024
reddyashish
reviewed
Oct 16, 2024
|
This is taken care of, I will leave the gif for posterity, as currently I have nothing to demonstrate the prompt with otherwise :/ But, just so it is clear, only |
- new greg version - API break fixed by introducing a new overload constructor - logging error when we try to navigate to a bad link in the package details (links are provided by package authors, so we cannot control the conversion to a valid URI) - comments to public properties - small UI aligment to enforce consistency of line height between packages with and without Host information
- first stab at replacing the static compatibility map with the one coming from the new greg route - struggling to find the best design patter for the most efficient way of serving the data to each individual `PackageManagerSearchElement` - `PackageManagerSearchElement` are internalized using only the 'Header' corresponding to each individual package - the `PackageManagerSearchElement` is part of the `DocumentationBrowserViewExtension` - Ideally the Compatibility Map is only loaded once per Dynamo session. Furthermore, we do that inside the PackageManagerSearchViewModel, which is part of `DynamoCoreWPF` - as a consequence, the individual `PackageManagerSearchElement`s have no visibility over the `PackageManagerSearchViewModel` - is the best way fowrard to make the `PackageManagerSearchViewModel` visible to the `PackageManagerSearchElement` and create the map a static property in a singleton?
- moved the static compatibility map to the PackageViewModel (thank you Aaron and Ashish!!!) - fixed tests - added test
dnenov
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7341
dnenov
changed the title
QilongTang
reviewed
Oct 18, 2024
src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerSearchElementViewModel.cs
Outdated
Show resolved
Hide resolved
|
|
zeusongit
approved these changes
Oct 21, 2024
QilongTang
reviewed
Oct 21, 2024
| @@ -237,5 +447,13 @@ private void DetectDependencies() | |||
| PythonVersion = pythonEngineVersions.Count > 0 ? string.Join(", ", pythonEngineVersions) : Dynamo.Properties.Resources.NoneString; | |||
| Hosts = hostDependencies.Count > 0 ? string.Join(", ", hostDependencies) : Dynamo.Properties.Resources.NoneString; | |||
| } | |||
|
|
|||
| private static string CapitalizeFirstLetter(string word) | |||
There was a problem hiding this comment.
We can maybe move this to utilityclass later
QilongTang
reviewed
Oct 21, 2024
| /// </summary> | ||
| /// <param name="dateString"></param> | ||
| /// <returns></returns> | ||
| private string GetFormattedDate(string dateString) |
QilongTang
approved these changes
Oct 21, 2024
9 tasks
QilongTang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Follow DYN-7341. Related tasks:
A redesign of the PM search & install functionality.
Current State
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@QilongTang
@zeusongit
FYIs