DYN-6633: Definedata hierarchy

doc/distrib/NodeHelpFiles/CoreNodeModels.DefineData.md

@@ -1,9 +1,30 @@
 ## In Depth
 
-Validates and returns data from a currently or previously connected input node.
+The Define Data Node is designed to work as in input node, while validating the data type of the incoming data (type can be 'string', 'point', 'boolean' or any data type that is currently supported by Dynamo. For the full list of supported data types, expand the Dropdown menu of the node). It uses upstream nodes to set default values to make setting the type data easier as well as making the graphs functional when the nodes are used.
+
+The node has 4 inputs:
+- the node '**>**' Input - can be connected to any downstream node to validate the input of
+- the **Dropdown** menu
+- the '**List**' toggle 
+- the '**Lock**' toggle
+
+The node has two distinct modes in terms of behaviour - the 'Manua' and 'Auto' mode. This are defined by the state of the 'Lock' toggle - locked is for 'Manual', whereas unlocked is for 'Auto' mode. 
+
+### Manual mode
+
+Set the **Lock** to locked position. The user sets the type of data explicitly by interacting with the **Dropdown** and **List** toggle. The node validates the data. If the validation is successful, the output of the node is the same as the input. If the validation is not successful, the node will enter a **Warning** state with a null output.
+
+### Auto mode
+
+Set the **Lock** to unlocked position. The downstream data is being automaticall validated. If the type of data is valid*, the node will automatically adjust the **Dropdown** and **List** toggles to match the input  data type. If the validation process is successful, the output of the node is the same as the input. If the validation process is not successful, the node will enter a **Warning** state with a null output.
+
+* data validity - the data is recognized by Dynamo (any of the **Dropdown** menu values) and the data is either a single objet or a List of homogeneous values, or a List of values that belong to the same hierarchical tree.
+
+In the example below, the first group of 'DefineData' nodes is in 'Manual' 'single value' mode - the node correctly validates the Number input provided, while rejecting the String input. The second group showscases a node in 'Auto' mode - the node automatically adjusts the 'Dropdown' and 'List' toggles to the desired inputs - in this case, list of integers.
 
 ---
 
 ## Example File
 
 ![Define_Data](./CoreNodeModels.DefineData_img.jpg)
+

src/DynamoCore/Engine/EngineController.cs

@@ -440,6 +440,9 @@ private bool VerifyGraphSyncData(IEnumerable<NodeModel> nodes)
             {
                 if (!node.IsInputNode) continue;
 
+                //We also don't want any nodes that do have input ports or where derived from custom nodes.
+                if (node.InPorts.Any() || node.IsCustomFunction) continue;
+
                 // Only one or the other of the two lists, Added or Modified, will match the node GUID if they do. 
                 bool isAdded = false;
                 for (int i = 0; i < graphSyncdata.AddedSubtrees.Count; i++)

src/DynamoCoreWpf/Properties/Resources.en-US.resx

@@ -3962,6 +3962,14 @@ To make this file into a new template, save it to a different folder, then move
   <data name="DynamoXmlFileFormat" xml:space="preserve">
     <value>Dynamo 1.x file format</value>
   </data>
+  <data name="DataInputNodeModeLockTooltip" xml:space="preserve">
+    <value>When locked, this node only accepts the selected data type as input. When unlocked, the input can be any supported data type.</value>
+    <comment>Tool-tip for the padlock toggle button controlling auto/manual mode.</comment>
+  </data>
+  <data name="DataInputNodeInformationTooltip" xml:space="preserve">
+    <value>Toggle on if the input data contains a list.</value>
+    <comment>Tool-tip for info questionmark icon.</comment>
+  </data>
   <data name="MessagePackageOlderDynamo" xml:space="preserve">
     <value>The package or one of its dependencies use an older version of {0} than you are currently using. Do you want to continue?</value>
   </data>
@@ -3970,5 +3978,5 @@ To make this file into a new template, save it to a different folder, then move
   </data>
   <data name="MessagePackOlderDynamoLink" xml:space="preserve">
     <value>#Learn more=https://primer2.dynamobim.org/1_developer_primer_intro/3_developing_for_dynamo/updating-your-packages-and-dynamo-libraries-for-dynamo-3x-net8</value>
-  </data>
+  </data>   
 </root>

src/DynamoCoreWpf/Properties/Resources.resx

@@ -3949,6 +3949,14 @@ To make this file into a new template, save it to a different folder, then move
   <data name="DynamoXmlFileFormat" xml:space="preserve">
     <value>Dynamo 1.x file format</value>
   </data>
+  <data name="DataInputNodeModeLockTooltip" xml:space="preserve">
+    <value>When locked, this node only accepts the selected data type as input. When unlocked, the input can be any supported data type.</value>
+    <comment>Tool-tip for the padlock toggle button controlling auto/manual mode.</comment>
+  </data>
+  <data name="DataInputNodeInformationTooltip" xml:space="preserve">
+    <value>Toggle on if the input data contains a list.</value>
+    <comment>Tool-tip for info questionmark icon.</comment>
+  </data>
   <data name="MessagePackageOlderDynamo" xml:space="preserve">
     <value>This package or one of its dependencies were created for a previous version of Dynamo. It may not work in this version. Do you want to continue?</value>
   </data>
@@ -3958,4 +3966,4 @@ To make this file into a new template, save it to a different folder, then move
   <data name="MessagePackOlderDynamoLink" xml:space="preserve">
     <value>#Learn more=https://primer2.dynamobim.org/1_developer_primer_intro/3_developing_for_dynamo/updating-your-packages-and-dynamo-libraries-for-dynamo-3x-net8</value>
   </data>
-</root>
+</root>

src/DynamoCoreWpf/PublicAPI.Unshipped.txt

@@ -4452,6 +4452,8 @@ static Dynamo.Wpf.Properties.Resources.CustomNodePropertyWindowName.get -> strin
 static Dynamo.Wpf.Properties.Resources.CustomNodePropertyWindowNameHint.get -> string
 static Dynamo.Wpf.Properties.Resources.CustomNodePropertyWindowTitle.get -> string
 static Dynamo.Wpf.Properties.Resources.CustomNodeTypeShortString.get -> string
+static Dynamo.Wpf.Properties.Resources.DataInputNodeInformationTooltip.get -> string
+static Dynamo.Wpf.Properties.Resources.DataInputNodeModeLockTooltip.get -> string
 static Dynamo.Wpf.Properties.Resources.DefaultPythonEngineNone.get -> string
 static Dynamo.Wpf.Properties.Resources.DeleteFailureMessageBoxTitle.get -> string
 static Dynamo.Wpf.Properties.Resources.DeprecatingPackageMessageBoxTitle.get -> string