DYN-6633: Definedata hierarchy #15154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- starting with the model and the test suite
- now types are contained inside an enum - added the basic primitives to the test structure, including lists checks - reworked the node to start getting the customization going (and make sense of the whole thing)
- created hierarchical container capable of tracking type inheritance - added all geometry tests
- finished all primitive date type tests
This reverts commit 1621855.
- completed tests checking inf inheritance works on individual and on list level
- removed the Enum, replaced directly with Type
- removed dictionary in favor of list of datatypes - renamed methods to better suit the specificity of the node functionality they were serving
- now returns the input as an output - not doing much with the result of the validation though, except returning to the first value of the drop-down
- added visual hierarchy to the view (ComboBox) - removed Parent, introduced Level for indenting
- started throwing to test functionality, need to provide correct warning messages - now correctly handles node when interacting with the toggle buttons (lock, list)
- added node icons - added node to the layoutSpecs
- added dashed lines to represent nesting and visual hierarchy - added localization exception and tooltip resources
Add ability to set value from Player
- no warning in case the node 'is not used' (no input is provided) - do not go back to 0 index if not in auto mode
- when in AutoMode, we assign 'select types' if null or wrong type is provided - fixed resolution issues with icons - fixed resources
- started adding node tests
- public static method of retrieving the list of datatypes replaced by an internal static property DataNodeDynamoTypeList
- added logic to handle lists when in AutoMode (guess the type, if possible) - added Tests - reintroduced 'Parent' to DataNodeDynamoType to speed up inheritance checks
- added updated error messages - added first draft of detailed node documentation - improved logic in handling inputData in AutoMode
- in case the node is in 'auto' mode, when user interacts with it, lock it - this is to prevent misunderstanding of what 'auto' mode does
- fix to DynamoPlayer behavior (from Craig) - adjustment to interaction with the node under AutoMode - now locks the node
UI Smoke TestsTest: success. 2 passed, 0 failed. |
- added new resources to api changes
- due to node Infos not being updated under a different test base, moved the tests to benefit from the VisualizationTest base
twastvedt
reviewed
May 9, 2024
Definedata hierarchy
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6633
twastvedt
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The 3rd PR of this node implementation, following #15022. The work in this PR contains a mostly finished node ready to be tested and where necessary improved upon.
The DefineData node will be used with the EngineNode to enable a much larger set of input/output types to be used when running 'graph-as-a-node'. (example below)
Usage with EngineNode
Current Interaction
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@saintentropy
@twastvedt
FYIs
@Amoursol
@mjkkirschner
@QilongTang