Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DYN-6535 DynamoRevit Improve Search Fix 2 #14917

Merged
merged 5 commits into from
Feb 6, 2024
Merged

DYN-6535 DynamoRevit Improve Search Fix 2 #14917

merged 5 commits into from
Feb 6, 2024

Conversation

RobertGlobant20
Copy link
Contributor

Purpose

Fixing specific case in DynamoRevit Search algorithm
The specific case "element set parameter" was failing on Revit 2025 (not finding anything), then I've modified the code so that check if the first term is a category if that is the case it will create a specific query using the first term as category and the next terms as node name.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Fixing specific case in DynamoRevit Search algorithm

Reviewers

@QilongTang

FYIs

@avidit

@RobertGlobant20
DYN-6535 DynamoRevit Improve Search Fix 2
5ef4493 
The specific case "element set parameter" was failing on Revit 2025 (not finding anything), then I've modified the code so that check if the first term is a category if that is the case it will create a specific query using the first term as category and the next terms as node name.
@RobertGlobant20
Copy link
Contributor Author

GIF showing the behavior in Revit 2025
chrome_CMhi2PDSG5

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2024 •
edited
Loading

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@RobertGlobant20
DYN-6535 DynamoRevit Improve Search Fix 2 Code Review
c62ba64 
Updating Linq query so that is executed only once.
@QilongTang QilongTang added this to the 3.1 milestone Feb 6, 2024
@QilongTang
Copy link
Contributor

Also @RobertGlobant20 Now that the API breaking change has been fixed, you should be able to test this with master changed pulled in

@RobertGlobant20
Squashed commit of the following:
c182c1b 
commit 3893c85
Author: Ashish Aggarwal <[email protected]>
Date:   Mon Feb 5 12:53:49 2024 -0500

    Fix retain package structure flow where nested directory at root level were lost (#14918)

    * optimize

    * comments and a test

    * add subdir test and comments

    * add child test

    * test updates

commit d0bd96e
Author: Aaron (Qilong) <[email protected]>
Date:   Fri Feb 2 15:56:03 2024 -0500

    Fix API breaking changes (#14916)

    * Fix API breaking changes

    * Update OpenFileCommand

    * update

commit 8f123fe
Author: Daria Ivanciucova <[email protected]>
Date:   Fri Feb 2 03:20:48 2024 +0000

    TSpline rename hashed nodes  (#14921)

    * renamed 2 nodes

    TSplineSurface.BySphereCenterPointRadius
    TSplineSurface.ByCylinderPointsRadiu

    * TSplineSurface.ByPlaneOriginNormal

    * TSplineSurface.ByQuadballCenterRadius

    * TSplineSurface.BySphereFourPoints

    * TSplineSurface.ByPlaneOriginNormalXAxis

    * TSplineSurface.ByPlaneOriginXAxisYAxis

    * TSplineVertex.FunctionalValence

    * TSplineSurface.ByConeCoordinateSystemHeightRadii

    * TSplineSurface.ByPlaneBestFitThroughPoints

    * TSplineSurface.ByPlaneLineAndPoint

    * TSplineSurface.ByPlaneThreePoints

    * TSplineSurface.ByTorusCenterRadii

    * TSplineSurface.ByTorusCoordinateSystemRadii

    * TSplineTopology.TPointVertices

    * TSplineSurface.AddReflections

    * TSplineSurface.DeleteVertices

    * TSplineSurface.CompressIndices

    * TSplineSurface.RemoveReflections

    * TSplineSurface.ByNurbsSurfaceUniform

    * TSplineSurface.UnweldVertices

    * TSplineSurface.BridgeFacesToEdges

    * TSplineReflection.SegmentsCount

    * TSplineSurface.ByNurbsSurfaceCurvature

    * TSplineSurface.BridgeEdgesToFaces

    * TSplineInitialSymmetry.IsRadial; TSplineInitialSymmetry.RadialSymmetryFaces

    * TSplineReflection.SegmentsAngle

    * .TSplineSurface.BridgeFacesToFaces

    * TSplineSurface.BridgeEdgesToEdges

    * TSplineInitialSymmetry.ByRadial

    * SplineSurface.ByCombinedTSplineSurfaces

    * TSplineSurface.UncreaseVertices

    * BuildFromLines

    * TSplineSurface.CreaseVertice

    * TSplineTopology.RegularVertices

    * TSplineTopology.VertexByIndex

    * TSplineSurface.DeserializeFromTSM

    * TSplineSurface.SerializeAsTSM

    * TSplineTopology.BorderVertices

    * TSplineSurface.EnableSmoothMode

    * TSplineTopology.NonManifoldVertices

    * TSplineTopology.VerticesCoun

    * TSplineSurface.DuplicateFaces

    * TSplineSurface.ExtrudeEdgesAlongCurve

    * TSplineTopology.StarPointVertices

    * TSplineTopology.NonManifoldEdges

    * TSplineSurface.WeldCoincidentVertices

    * TSplineSurface.SubdivideFaces

    * TSplineSurface.ExtrudeFacesAlongCurve

    * TSplineSurface.ByConeCoordinateSystemHeightRadius

    * TSplineSurface.ByCylinderRadiusHeight

commit 2bb51dc
Author: Daria Ivanciucova <[email protected]>
Date:   Thu Feb 1 17:43:53 2024 +0000

    TSpline Nodes Documentation - Third set (#14598)

    * FillHole, IsClosed, IsInBoxMode

    * BorderFaces, BorderEdges, BorderVertices, DuplicateFaces

    * EnableSmoothMode, ExportToTSS, ExportToTSM

    * ImportFromTSM (2)

    * ImportFromTSS(2)

    * ExtrudeFaces, Interpolate, SubdivideFaces, FlattenVertices (2)

    * IsStandard, Standardize, Thicken (2)

    * Decomposed (3), EdgeByIndex, EdgeCount, InnerEdges, InnerFaces, InnerVertices, NGonFaces, NonManifoldEdges, NonManifoldVertices

    * RegularFaces, RegularVertices, StarPoints, TPoints

    * Repair, Serialize, Deserialize

    * ExtrudeEdges, ExtrudeEdgesAlongCurve, ExtrudeFacesAlongCurve

    * FlipNormals, IsExtractable

    * MoveVertices, FaceByIndex, VertexByIndex

    * Is Watertight, FacesCount, VerticesCount, SlideEdges, MergeEdges, WeldCoincidentVertices, WeldVertices(2)

    * ToBrep, ToMesh

    * Update WSNXB54TDQEZRTUNRFCTUDK74DHVPQPXBXEYJUZJPW6T2F7XERDQ.md

    * CreateMatch (2), PullVertices

    * MakeUniform

    * updated to better method for highlighting edges

    * spell check

    * Update 6ICXLN4V6DNK5KMYTY5LPCJBE27IRW5VOBKCCVFQGO3HST752ZNQ.md

    * added TSM, TSS files, typos

    * Helena's comments

    ---------

    Co-authored-by: Deyan Nenov <[email protected]>
    Co-authored-by: Aaron (Qilong) <[email protected]>

commit 9136633
Author: Daria Ivanciucova <[email protected]>
Date:   Thu Feb 1 16:59:41 2024 +0000

    TSpline Nodes Documentation - Second set (#14550)

    * TSplineInitialSymmetry nodes

    * TSplineReflection nodes documentation

    * two more Reflections nodes

    * 7 more nodes

    - Bevel Edges
    - Crease Edges
    - Crease Vertices
    - Uncrease Edges
    - Uncrease Vertices
    - Unweld Edges
    - Unweld Vertices

    * ByNurbs and ByCombinedSurfaces

    - ByNurbsSurfaceCurvature
    -ByNurbsSurfaceUniform
    - ByCombinedTSplineSurfaces

    * 4 Bridge nodes

    * Compress Indexes, BySweep, ByRevolve, BuildFromLines

    * DeleteEdges, DeleteFaces, DeleteVertices

    * Update Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.BridgeEdgesToEdges.md

    * Update Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.BridgeEdgesToFaces.md

    * Update Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.BridgeFacesToEdges.md

    * Update Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.BridgeFacesToFaces.md

    * Update Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.BuildFromLines.md

    * added missing TSplineSurface.Reflections node

    * Helena's comments

    ---------

    Co-authored-by: Deyan Nenov <[email protected]>
    Co-authored-by: Aaron (Qilong) <[email protected]>

commit 99cf281
Author: Deyan Nenov <[email protected]>
Date:   Thu Feb 1 16:58:27 2024 +0000

    binding issues resolved (#14682)

    - fixed null exception when trying to assign click handler on a context menu button when the parent button
    - also fixed another incorrect binding issue

commit d2e57b5
Author: Daria Ivanciucova <[email protected]>
Date:   Thu Feb 1 15:58:29 2024 +0000

    TSpline Nodes Documentation - First set (#14549)

    * TSEdge and TSFace nodes documentation

    * TSpline Vertex nodes documentation

    * TSpline.UVNFrame nodes documentation

    * Update Autodesk.DesignScript.Geometry.TSpline.TSplineVertex.IsStarPoint.md

    * TSpline Box docs

    * TSplineSurface.ByPlane nodes docs

    * TSplineSurface.ByCone docs

    * TSplineSurface - Cylinder docs

    * TSplineSurface.ByQuadball nodes

    * replaced with renamed files for ByBox nodes

    * BySphere nodes

    * TSplineSurface.ByTorus nodes

    * BuildPipes and ByExtrude

    * Update Autodesk.DesignScript.Geometry.TSpline.TSplineVertex.Index.md

    * corrected the description for Torus nodes

    * Helena's comments

    ---------

    Co-authored-by: Deyan Nenov <[email protected]>
    Co-authored-by: Aaron (Qilong) <[email protected]>
@RobertGlobant20
Copy link
Contributor Author

Also @RobertGlobant20 Now that the API breaking change has been fixed, you should be able to test this with master changed pulled in

@QilongTang I just updated the master branch with latest changes and merge it into the feature branch and is working as expected.
chrome_4oThzDcwFn

@QilongTang
Copy link
Contributor

@RobertGlobant20 It's strange that the git diff now shows you touched all those file of node help docs..

QilongTang
QilongTang reviewed Feb 6, 2024
View reviewed changes
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is there a way to add a unit test for this improvement?

@RobertGlobant20
Copy link
Contributor Author

@RobertGlobant20 It's strange that the git diff now shows you touched all those file of node help docs..

@QilongTang fixed, When merging the master branch I did a "Squash and Merge" but I just reverted and did a "Create a merge commit" and now is reflecting the right files.

@RobertGlobant20
Copy link
Contributor Author

LGTM, is there a way to add a unit test for this improvement?

@QilongTang probably just for DynamoSandbox specifically testing that when you type "list " or "input " you should get nodes under that specific category.

@QilongTang
Copy link
Contributor

LGTM, is there a way to add a unit test for this improvement?

@QilongTang probably just for DynamoSandbox specifically testing that when you type "list " or "input " you should get nodes under that specific category.

That's fine, can you give it a try to wrap this up?

@RobertGlobant20
Copy link
Contributor Author

LGTM, is there a way to add a unit test for this improvement?

@QilongTang probably just for DynamoSandbox specifically testing that when you type "list " or "input " you should get nodes under that specific category.

That's fine, can you give it a try to wrap this up?

@QilongTang I just tested several criteria in DynamoSandbox and got the same results than previous versions.
This change just apply for a specific case in Revit due that when you search for "element set parameter" Revit has several nodes which name contains "set" and "parameters" so was showing those nodes first and after my fix is showing the "Element.Setparameterbyname" will be shown at the top and then the other nodes.
Then I think we cannot create a unit test for this feature unless all the revit nodes are indexed.

@QilongTang
Copy link
Contributor

@RobertGlobant20 Thanks. LGTM then

@QilongTang QilongTang merged commit d01e057 into DynamoDS:master Feb 6, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reddyashish reddyashish reddyashish left review comments

@QilongTang QilongTang QilongTang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@RobertGlobant20 @QilongTang @reddyashish