Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PM - resolve lingering binding issues #14682

Merged
merged 1 commit into from
Feb 1, 2024
Merged

PM - resolve lingering binding issues #14682

merged 1 commit into from
Feb 1, 2024

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Dec 4, 2023 •
edited
Loading

Purpose

2 binding issues that would throw errors but won't cause a crash or malfunction of the package manager. Those were now resolved with this PR.

  • install-package button drop-down context menu (to specific folder) - the drop-down context menu button is part of the style of the parent button. Assigning a click-handler to it would cause an error if the parent button was not assigned already.
  • incorrect assignment of installedPackages Visibility property, now fixed

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • fixed null exception when trying to assign a click handler on a context menu button when the parent button
  • also fixed another incorrect binding issue to the installedPackages visibility property

Reviewers

@mjkkirschner
@reddyashish

FYIs

@dnenov
binding issues resolved
8e4239c 
- fixed null exception when trying to assign click handler on a context menu button when the parent button
- also fixed another incorrect binding issue
@reddyashish
Copy link
Contributor

https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/1335/

@QilongTang
Copy link
Contributor

Tests passing at https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/1353/

@QilongTang QilongTang added this to the 3.0 milestone Dec 15, 2023
@QilongTang QilongTang modified the milestones: 3.0, 3.1 Jan 3, 2024
@QilongTang
Copy link
Contributor

@reddyashish I moved this to 3.1 milestone, let me know when you would like to revisit this when we are ready to release this work.

@dnenov
Copy link
Collaborator Author

dnenov commented Jan 26, 2024

Do you think this one is OK to be merged? It's rather old now, should we go for it or close @mjkkirschner , @reddyashish , @QilongTang ? Just to remind us, the PR fixes some internal WPF errors which manifest during debugging of Dynamo and when CLR Exceptions are switched on.

@reddyashish
Copy link
Contributor

reddyashish commented Feb 1, 2024 •
edited
Loading

The idea of sub-ing and unsub-ing the same DropDownInstallButton_OnClick event in the same method was confusing but looking at the comments, we decided it go with that approach to fix multiple binding issues.
Tests have passed. Looks good to be merged.

@reddyashish reddyashish merged commit 99cf281 into DynamoDS:master Feb 1, 2024
21 checks passed
@reddyashish
Copy link
Contributor

@QilongTang Plan this for 3.0.4 release or good with 3.1?

@QilongTang
Copy link
Contributor

@reddyashish I am fine with both options

QilongTang pushed a commit that referenced this pull request Feb 6, 2024
@RobertGlobant20
DYN-6535 DynamoRevit Improve Search Fix 2 (#14917)
d01e057 
* DYN-6535 DynamoRevit Improve Search Fix 2

The specific case "element set parameter" was failing on Revit 2025 (not finding anything), then I've modified the code so that check if the first term is a category if that is the case it will create a specific query using the first term as category and the next terms as node name.

* DYN-6535 DynamoRevit Improve Search Fix 2 Code Review

Updating Linq query so that is executed only once.

* Squashed commit of the following:

commit 3893c85
Author: Ashish Aggarwal <[email protected]>
Date:   Mon Feb 5 12:53:49 2024 -0500

    Fix retain package structure flow where nested directory at root level were lost (#14918)

    * optimize

    * comments and a test

    * add subdir test and comments

    * add child test

    * test updates

commit d0bd96e
Author: Aaron (Qilong) <[email protected]>
Date:   Fri Feb 2 15:56:03 2024 -0500

    Fix API breaking changes (#14916)

    * Fix API breaking changes

    * Update OpenFileCommand

    * update

commit 8f123fe
Author: Daria Ivanciucova <[email protected]>
Date:   Fri Feb 2 03:20:48 2024 +0000

    TSpline rename hashed nodes  (#14921)

    * renamed 2 nodes

    TSplineSurface.BySphereCenterPointRadius
    TSplineSurface.ByCylinderPointsRadiu

    * TSplineSurface.ByPlaneOriginNormal

    * TSplineSurface.ByQuadballCenterRadius

    * TSplineSurface.BySphereFourPoints

    * TSplineSurface.ByPlaneOriginNormalXAxis

    * TSplineSurface.ByPlaneOriginXAxisYAxis

    * TSplineVertex.FunctionalValence

    * TSplineSurface.ByConeCoordinateSystemHeightRadii

    * TSplineSurface.ByPlaneBestFitThroughPoints

    * TSplineSurface.ByPlaneLineAndPoint

    * TSplineSurface.ByPlaneThreePoints

    * TSplineSurface.ByTorusCenterRadii

    * TSplineSurface.ByTorusCoordinateSystemRadii

    * TSplineTopology.TPointVertices

    * TSplineSurface.AddReflections

    * TSplineSurface.DeleteVertices

    * TSplineSurface.CompressIndices

    * TSplineSurface.RemoveReflections

    * TSplineSurface.ByNurbsSurfaceUniform

    * TSplineSurface.UnweldVertices

    * TSplineSurface.BridgeFacesToEdges

    * TSplineReflection.SegmentsCount

    * TSplineSurface.ByNurbsSurfaceCurvature

    * TSplineSurface.BridgeEdgesToFaces

    * TSplineInitialSymmetry.IsRadial; TSplineInitialSymmetry.RadialSymmetryFaces

    * TSplineReflection.SegmentsAngle

    * .TSplineSurface.BridgeFacesToFaces

    * TSplineSurface.BridgeEdgesToEdges

    * TSplineInitialSymmetry.ByRadial

    * SplineSurface.ByCombinedTSplineSurfaces

    * TSplineSurface.UncreaseVertices

    * BuildFromLines

    * TSplineSurface.CreaseVertice

    * TSplineTopology.RegularVertices

    * TSplineTopology.VertexByIndex

    * TSplineSurface.DeserializeFromTSM

    * TSplineSurface.SerializeAsTSM

    * TSplineTopology.BorderVertices

    * TSplineSurface.EnableSmoothMode

    * TSplineTopology.NonManifoldVertices

    * TSplineTopology.VerticesCoun

    * TSplineSurface.DuplicateFaces

    * TSplineSurface.ExtrudeEdgesAlongCurve

    * TSplineTopology.StarPointVertices

    * TSplineTopology.NonManifoldEdges

    * TSplineSurface.WeldCoincidentVertices

    * TSplineSurface.SubdivideFaces

    * TSplineSurface.ExtrudeFacesAlongCurve

    * TSplineSurface.ByConeCoordinateSystemHeightRadius

    * TSplineSurface.ByCylinderRadiusHeight

commit 2bb51dc
Author: Daria Ivanciucova <[email protected]>
Date:   Thu Feb 1 17:43:53 2024 +0000

    TSpline Nodes Documentation - Third set (#14598)

    * FillHole, IsClosed, IsInBoxMode

    * BorderFaces, BorderEdges, BorderVertices, DuplicateFaces

    * EnableSmoothMode, ExportToTSS, ExportToTSM

    * ImportFromTSM (2)

    * ImportFromTSS(2)

    * ExtrudeFaces, Interpolate, SubdivideFaces, FlattenVertices (2)

    * IsStandard, Standardize, Thicken (2)

    * Decomposed (3), EdgeByIndex, EdgeCount, InnerEdges, InnerFaces, InnerVertices, NGonFaces, NonManifoldEdges, NonManifoldVertices

    * RegularFaces, RegularVertices, StarPoints, TPoints

    * Repair, Serialize, Deserialize

    * ExtrudeEdges, ExtrudeEdgesAlongCurve, ExtrudeFacesAlongCurve

    * FlipNormals, IsExtractable

    * MoveVertices, FaceByIndex, VertexByIndex

    * Is Watertight, FacesCount, VerticesCount, SlideEdges, MergeEdges, WeldCoincidentVertices, WeldVertices(2)

    * ToBrep, ToMesh

    * Update WSNXB54TDQEZRTUNRFCTUDK74DHVPQPXBXEYJUZJPW6T2F7XERDQ.md

    * CreateMatch (2), PullVertices

    * MakeUniform

    * updated to better method for highlighting edges

    * spell check

    * Update 6ICXLN4V6DNK5KMYTY5LPCJBE27IRW5VOBKCCVFQGO3HST752ZNQ.md

    * added TSM, TSS files, typos

    * Helena's comments

    ---------

    Co-authored-by: Deyan Nenov <[email protected]>
    Co-authored-by: Aaron (Qilong) <[email protected]>

commit 9136633
Author: Daria Ivanciucova <[email protected]>
Date:   Thu Feb 1 16:59:41 2024 +0000

    TSpline Nodes Documentation - Second set (#14550)

    * TSplineInitialSymmetry nodes

    * TSplineReflection nodes documentation

    * two more Reflections nodes

    * 7 more nodes

    - Bevel Edges
    - Crease Edges
    - Crease Vertices
    - Uncrease Edges
    - Uncrease Vertices
    - Unweld Edges
    - Unweld Vertices

    * ByNurbs and ByCombinedSurfaces

    - ByNurbsSurfaceCurvature
    -ByNurbsSurfaceUniform
    - ByCombinedTSplineSurfaces

    * 4 Bridge nodes

    * Compress Indexes, BySweep, ByRevolve, BuildFromLines

    * DeleteEdges, DeleteFaces, DeleteVertices

    * Update Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.BridgeEdgesToEdges.md

    * Update Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.BridgeEdgesToFaces.md

    * Update Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.BridgeFacesToEdges.md

    * Update Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.BridgeFacesToFaces.md

    * Update Autodesk.DesignScript.Geometry.TSpline.TSplineSurface.BuildFromLines.md

    * added missing TSplineSurface.Reflections node

    * Helena's comments

    ---------

    Co-authored-by: Deyan Nenov <[email protected]>
    Co-authored-by: Aaron (Qilong) <[email protected]>

commit 99cf281
Author: Deyan Nenov <[email protected]>
Date:   Thu Feb 1 16:58:27 2024 +0000

    binding issues resolved (#14682)

    - fixed null exception when trying to assign click handler on a context menu button when the parent button
    - also fixed another incorrect binding issue

commit d2e57b5
Author: Daria Ivanciucova <[email protected]>
Date:   Thu Feb 1 15:58:29 2024 +0000

    TSpline Nodes Documentation - First set (#14549)

    * TSEdge and TSFace nodes documentation

    * TSpline Vertex nodes documentation

    * TSpline.UVNFrame nodes documentation

    * Update Autodesk.DesignScript.Geometry.TSpline.TSplineVertex.IsStarPoint.md

    * TSpline Box docs

    * TSplineSurface.ByPlane nodes docs

    * TSplineSurface.ByCone docs

    * TSplineSurface - Cylinder docs

    * TSplineSurface.ByQuadball nodes

    * replaced with renamed files for ByBox nodes

    * BySphere nodes

    * TSplineSurface.ByTorus nodes

    * BuildPipes and ByExtrude

    * Update Autodesk.DesignScript.Geometry.TSpline.TSplineVertex.Index.md

    * corrected the description for Torus nodes

    * Helena's comments

    ---------

    Co-authored-by: Deyan Nenov <[email protected]>
    Co-authored-by: Aaron (Qilong) <[email protected]>

* Revert "Squashed commit of the following:"

This reverts commit c182c1b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjkkirschner mjkkirschner mjkkirschner left review comments

@reddyashish reddyashish reddyashish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@dnenov @reddyashish @QilongTang @mjkkirschner