-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AGD-3133: Add Dynamo Preference Non-UI Flag for legacy behavior #14575
Conversation
Whats the use case here? Concern is that it will be very easy for a dev to remove this thinking it's not used etc. |
Should we use inheritance so DynamoRevit actually has a settings object slightly different from sandbox? Does this apply to C3D? My concern is that this setting seems to only surface in Player and is not settable in Dynamo. |
I will update the comments on this implementation but @mjkkirschner and @QilongTang the goal here is to fix bugs that are being reported due to a legacy issue with the Dynamo Player server. (I added more detail to the description) We have planned to depreciate this behavior but follow the Revit model of providing an options to customers that really need the old way for one release year but require them to make a change in a config file. |
Not sure if that answers you question @QilongTang. The goal is to give each host the option to set this config for the application |
@saintentropy can you add a test? |
hey @saintentropy theres also a failure in here from some other preferences tests |
@mjkkirschner Good to go? |
Purpose
Add Non preference UI flag to Dynamo to allow users to enable legacy behavior of Dynamo Player graph parsing related to Outputs. When the player was first introduced there were no
isOutput
property on the nodes. The various players used the renamed watch as a single to the Player to use them as outputs. Now that Dynamo has the output property the old behavior is causing bug reports. This change will allow the player to remove the old option but support it for a period of time. This flag and support will be removed in Dynamo 4.0.https://jira.autodesk.com/browse/AGD-3133
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
For Dynamo Player, the legacy behavior for setting an output was a renamed Watch node. This method was still supported when the IsOutput property was introduced. Dynamo Player is now deprecating the renamed Watch node method and adding support via Dynamo config file. This config option will be removed in a future release.
Reviewers
@mjkkirschner @twastvedt
FYIs
@QilongTang