Add Dynamo Preference Non-UI Flag for legacy behavior (#14575)

* Add flag * Update comment * UpdateTests --------- Co-authored-by: Craig Long <[email protected]> Co-authored-by: Michael Kirschner <[email protected]>
DynamoDS · Nov 13, 2023 · 40e4357 · 40e4357
1 parent 4971e9d
commit 40e4357
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/src/DynamoCore/Configuration/PreferenceSettings.cs b/src/DynamoCore/Configuration/PreferenceSettings.cs
@@ -835,6 +835,12 @@ public string IronPythonResolveTargetVersion
 
         #region Dynamo Player and Generative Design settings
 
+        /// <summary>
+        /// Enable legacy behavior for Dynamo Player to allow renamed Watch nodes to be seen as graph output.
+        /// This flag is for use in the 2024 product release year and can removed for 2025
+        /// </summary>
+        public bool EnableDynamoPlayerRenamedWatchAsOutput { get; set; }
+
         /// <summary>
         /// Collections of folders used by individual Dynamo Player or Generative Design as entry points.
         /// </summary>
@@ -906,6 +912,7 @@ public PreferenceSettings()
             ViewExtensionSettings = new List<ViewExtensionSettings>();
             GroupStyleItemsList = new List<GroupStyleItem>();
             ReadNotificationIds = new List<string>();
+            EnableDynamoPlayerRenamedWatchAsOutput = false;
             DynamoPlayerFolderGroups = new List<DynamoPlayerFolderGroup>();
             backupLocation = string.Empty;
         }

diff --git a/test/DynamoCoreTests/Configuration/PreferenceSettingsTests.cs b/test/DynamoCoreTests/Configuration/PreferenceSettingsTests.cs
@@ -70,6 +70,7 @@ public void TestSettingsSerialization()
             Assert.AreEqual(settings.ViewExtensionSettings.Count, 0);
             Assert.AreEqual(settings.DefaultRunType, RunType.Automatic);
             Assert.AreEqual(settings.DynamoPlayerFolderGroups.Count, 0);
+            Assert.AreEqual(settings.EnableDynamoPlayerRenamedWatchAsOutput, false);
             Assert.AreEqual(settings.Locale, "Default");
 
             // Save
@@ -89,6 +90,7 @@ public void TestSettingsSerialization()
             Assert.AreEqual(settings.ViewExtensionSettings.Count, 0);
             Assert.AreEqual(settings.DefaultRunType, RunType.Automatic);
             Assert.AreEqual(settings.DynamoPlayerFolderGroups.Count, 0);
+            Assert.AreEqual(settings.EnableDynamoPlayerRenamedWatchAsOutput, false);
             Assert.AreEqual(settings.Locale, "Default");
 
             // Change setting values
@@ -136,6 +138,7 @@ public void TestSettingsSerialization()
                     }
                 }
             });
+            settings.EnableDynamoPlayerRenamedWatchAsOutput = true;
             settings.Locale = "zh-CN";
 
 
@@ -173,6 +176,7 @@ public void TestSettingsSerialization()
             Assert.AreEqual(styleItemsList.HexColorString, "000000");
             Assert.AreEqual(settings.DynamoPlayerFolderGroups.Count, 1);
             Assert.AreEqual(settings.DynamoPlayerFolderGroups[0].Folders.Count, 1);
+            Assert.AreEqual(settings.EnableDynamoPlayerRenamedWatchAsOutput, true);
             Assert.AreEqual(settings.Locale, "zh-CN");
         }
 

diff --git a/test/settings/DynamoSettings-NewSettings.xml b/test/settings/DynamoSettings-NewSettings.xml
@@ -128,6 +128,7 @@
   <ReadNotificationIds>
     <string>1</string>
   </ReadNotificationIds>
+  <EnableDynamoPlayerRenamedWatchAsOutput>true</EnableDynamoPlayerRenamedWatchAsOutput>
   <DynamoPlayerFolderGroups>
    <DynamoPlayerFolderGroup/>
   </DynamoPlayerFolderGroups>