Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for element binding messagebox display on saveas #14424

Merged
merged 10 commits into from
Sep 21, 2023
Merged

Fix for element binding messagebox display on saveas #14424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
64b4706
remove coreclr-ncalc references
aparajit-pratap Aug 23, 2023
4a82ae7
Merge branch 'master' of github.com:DynamoDS/Dynamo
aparajit-pratap Aug 25, 2023
dbc3e12
Merge branch 'master' of github.com:DynamoDS/Dynamo
aparajit-pratap Aug 30, 2023
81ace20
Merge branch 'master' of github.com:DynamoDS/Dynamo
aparajit-pratap Aug 31, 2023
a7cafdc
Merge branch 'master' of github.com:DynamoDS/Dynamo
aparajit-pratap Sep 6, 2023
55c654d
Merge branch 'master' of github.com:DynamoDS/Dynamo
aparajit-pratap Sep 6, 2023
7ede2a4
Merge branch 'master' of github.com:DynamoDS/Dynamo
aparajit-pratap Sep 7, 2023
c43a02d
Merge branch 'master' of github.com:DynamoDS/Dynamo
aparajit-pratap Sep 8, 2023
1951d1a
Merge branch 'master' of github.com:DynamoDS/Dynamo
aparajit-pratap Sep 20, 2023
2b2afd8
fix for element binding messagebox on saveas
aparajit-pratap Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/DynamoCoreWpf/ViewModels/Core/WorkspaceViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,7 +628,7 @@ internal void Save(string filePath, bool isBackup = false, EngineController engi
{
// For intentional SaveAs either through UI or API calls, replace workspace elements' Guids and workspace Id
jo["Uuid"] = Guid.NewGuid().ToString();
if (jo["Bindings"] != JToken.Parse("[]"))
if (jo["Bindings"] != null && jo["Bindings"].Any())
{
jo["Bindings"] = JToken.Parse("[]");

Expand Down
3 changes: 2 additions & 1 deletion test/DynamoCoreWpfTests/DynamoViewTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,8 @@ public void ElementBinding_SaveAs()
File.Delete(filePath);
File.Delete(saveAsPath);
}


[Test]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this unit test was not run before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently not.

public void TestToastNotificationClosingBehavior()
{
var preferencesWindow = new PreferencesView(View);
Expand Down