Fix for element binding messagebox display on saveas #14424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aparajit-pratap
changed the title
QilongTang
reviewed
Sep 20, 2023
| @@ -170,7 +170,8 @@ public void ElementBinding_SaveAs() | |||
| File.Delete(filePath); | |||
| File.Delete(saveAsPath); | |||
| } | |||
|
|
|||
|
|
|||
| [Test] | |||
There was a problem hiding this comment.
Ah this unit test was not run before?
There was a problem hiding this comment.
Apparently not.
QilongTang
approved these changes
Sep 21, 2023
aparajit-pratap
added a commit
to aparajit-pratap/Dynamo
that referenced
this pull request
Mar 19, 2024
* remove coreclr-ncalc references * fix for element binding messagebox on saveas
9 tasks
QilongTang
pushed a commit
that referenced
this pull request
Mar 20, 2024
* DYN-6527: Fix graph update for primitive input nodes that are first initialized to null (#14703) * remove coreclr-ncalc references * add failing test for dropdown node * cleanup * update tests * attempt initial fix * cleanup * update test * review comments * add code comments * cherry-pick PR 14637 * cherry-pick PR 14394 * cherry-pick PR 14740 * Fix for element binding messagebox display on saveas (#14424) * remove coreclr-ncalc references * fix for element binding messagebox on saveas * cherry pick PRs 14424, 14500 * build fix --------- Co-authored-by: Michael Kirschner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix for element binding messagebox display on saveas - the previous check didn't work for guarding against trace data being empty before showing the message box - this is fixed here.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of