Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable file migration for 0.7.0 #1356

Merged
merged 7 commits into from
Mar 24, 2014

Conversation

Benglin
Copy link
Contributor

@Benglin Benglin commented Mar 24, 2014

This pull request addresses the following defect:

MAGN-2381 Disable auto migration and warn users if they are trying to open older version file.

It also implements a new GenericTaskDialog for use in displaying the error message. In the near future, CrashPrompt will be replaced by this dialog.

A note about dummy nodes

A dummy node can be seen in the following scenarios:

  1. When a migration method decides to make one
  2. When a type of a node cannot be resolved
  3. When a function cannot be resolved in DSFunction or DSVarArgFunction

Item #1 can no longer happen after this change, but the other two are still pretty much valid use cases. So please do not be alarmed if dummy nodes show up on canvas.

lukechurch added a commit that referenced this pull request Mar 24, 2014
Disable file migration for 0.7.0
@lukechurch lukechurch merged commit 55cccd8 into DynamoDS:ChocoButter-2Become1 Mar 24, 2014
@Benglin Benglin deleted the MAGN-2381 branch March 25, 2014 01:12
sharadkjaiswal pushed a commit to sharadkjaiswal/Dynamo that referenced this pull request Mar 31, 2014
Disable file migration for 0.7.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants