Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins nodes #1

Closed
gregorvilkner opened this issue Mar 19, 2012 · 1 comment
Closed

plugins nodes #1

gregorvilkner opened this issue Mar 19, 2012 · 1 comment

Comments

@gregorvilkner
Copy link

Hi there,

got a suggestion for AddElement_Click(object sender, RoutedEventArgs e) in the dynBench.xaml.cs.

currently you won't make it past the builtinTypes[mi.Header.ToString()] for types that are in the userTypes collection.

Is the User Node supposed to work? Even as a node that doesn't do anything? Here it doesn't manage to initialize a new node.

Kind regards,
Gregor

    private void AddElement_Click(object sender, RoutedEventArgs e)
    {
        System.Windows.Controls.MenuItem mi = e.Source as System.Windows.Controls.MenuItem;

        TypeLoadData tld = null;
        if (builtinTypes.ContainsKey(mi.Header.ToString()))
        {
            tld = builtinTypes[mi.Header.ToString()] as TypeLoadData;
            ...
        }
        else if (userTypes.ContainsKey(mi.Header.ToString()))
        {
            tld = userTypes[mi.Header.ToString()] as TypeLoadData;
            if (tld != null)
            {
                dynElement newEl = AddDynElement(tld.t, tld.assembly, mi.Header.ToString(), Guid.NewGuid(), 0.0, 0.0);
                ...
            }
        }
    }
@Steell Steell closed this as completed Jun 12, 2012
@Steell
Copy link
Contributor

Steell commented Jun 12, 2012

Issue no longer relevant.

sharadkjaiswal added a commit that referenced this issue Oct 31, 2014
Merge DynamoDS/Dynamo RC0.7.3_master
theanh0512 pushed a commit to theanh0512/Dynamo that referenced this issue Dec 12, 2014
Created Resources.resx for ProtoImperative and ProtoAssociative
Steell added a commit that referenced this issue Dec 19, 2014
Delete superfluous stuff
Randy-Ma pushed a commit that referenced this issue Mar 12, 2015
ikeough pushed a commit to ikeough/Dynamo that referenced this issue Jun 16, 2015
QilongTang pushed a commit that referenced this issue May 22, 2020
* Add Engine property to PythonNodeBase

* Add engine selector dropdown to python editor

* Add notification API to nodemodel

* add warnings to resources

* Add IronPython dialog on open saved workspace

* Add Engine label on node

* make LogNotification internal

* python engine enum

* Python migration extension DRAFT (#1)

* Python migration extension DRAFT

* update extension

* small cleanup

* move dialog and notification strings to extension resource

* Update PythonMigrationViewExtension.cs

* added python engine label to From String Node

* add engine selector to python script from string node in context menu

* Update EngineLabel.xaml

* comment updates

* Update Dynamo.All.sln

* Update PythonMigrationViewExtension.cs

* Update PythonMigrationViewExtension.cs

* comment updates

* Update Resources.Designer.cs

* update csproj + small cleanup

* added more information btn to IronPythonDialog

* comment updates

* tests added

* tests

* comment updates

* Updates dialog, notification and documentationbrowser text

* update tests

* fix dialog box and small clean up

* warning html update

* updates to warning messages

* Update PythonStringNode.cs

Co-authored-by: Michael Dewberry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants