Fix Regression with GetCLRObject impacting Node Preview and Tessellation #13363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjkkirschner
approved these changes
Sep 30, 2022
This was referenced Sep 30, 2022
Merged
| //checks for this edge case by verifying that the requested StackValue pointer is associated with an | ||
| //imported library. An example is the "Function" pointer which does not have an associated CLRObject. | ||
| //In that case, the return value should be null. | ||
| var classNode = runtimeCore.DSExecutable.classTable.GetClassNodeAtIndex(svData.metaData.type); |
There was a problem hiding this comment.
I believe GetClassNodeAtIndex was also introduced as part of the previous fixes. I suppose it's no longer needed as this line of code has been removed. Can the function, therefore, be removed?
There was a problem hiding this comment.
Yep it can be... I will file a follow up to re-look at this optimization. And we can either to fix the optimization or clear up that function too
|
Let's also wait to merge this until tests pass as I see tests were added in the linked prs. |
|
pass here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This fix addresses a regression found in Dynamo 2.16 related to the preview bubble and tessellation for the background preview. After installing a package during a session both would stop working correctly. This appears to be relates to changes introduced in #12934 and #11920. This PR reverts the behavior to the previous code.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Corrects regression in Dynamo where after installing a package during a session the node preview bubble and background preview would not operate correctly.
Reviewers
@mjkkirschner
FYIs
@aparajit-pratap @QilongTang @pinzart