GraphicDataProvider Fix: Regression for pointer referencing non-clr objects #12934
Conversation
| //imported library. An example is the "Function" pointer which does not have an associated CLRObject. | ||
| //In that case, the return value should be null. | ||
| var classNode = runtimeCore.DSExecutable.classTable.GetClassNodeAtIndex(svData.metaData.type); | ||
| if (classNode != null && !classNode.IsImportedClass) |
There was a problem hiding this comment.
Is checking if it's not an imported class a sufficient condition to determine that it's a function object? My concern is that there could be (if not today) in the future, other DS types that are not treated as imported classes for which we may not want to return null.
There was a problem hiding this comment.
Can we use this condition instead?
There was a problem hiding this comment.
Based on our discussion, I think it's okay to leave this as-is for now. LGTM!
There was a problem hiding this comment.
This may have been a pre-existing issue then. This fix just returns the function to its previous behavior.
|
Can we add a test case so that we don't miss a regression like this in the future? |
|
Yep let me take a look |
|
|
||
| var value = GetPreviewValue("42ac0cec-442f-4e4a-b629-1260f6db3d86"); | ||
| Assert.Null(value); | ||
| } |
There was a problem hiding this comment.
This test seems to pass even before this fix. Can you create one that fails before this fix?
Purpose
This PR fixes a regression associated with task https://jira.autodesk.com/browse/DYN-4229 and the #11920. This adds back the check for edge cases where some Pointers are not associated with CLR Objects. That is determined by checking the associated Class within the VM ClassTable is an external library.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@sm6srw @aparajit-pratap
FYIs
@QilongTang @Amoursol