Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't initialize the direct manipulation extension when asm is not loaded #13219

Merged
merged 6 commits into from
Aug 15, 2022
Merged

don't initialize the direct manipulation extension when asm is not loaded #13219

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
11a1530
wrap libg use in try catch
mjkkirschner Aug 12, 2022
4a9075d
Merge branch 'master' into crashnogeo
mjkkirschner Aug 15, 2022
377a477
more comments
mjkkirschner Aug 15, 2022
cedbc1e
Merge branch 'crashnogeo' of https://github.com/mjkkirschner/Dynamo i…
mjkkirschner Aug 15, 2022
79c7856
review comments
mjkkirschner Aug 15, 2022
b96c98c
attempt to make isAsmLoaded availible for internal extensions
mjkkirschner Aug 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/DynamoManipulation/NodeManipulator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,19 +494,17 @@ private RenderPackageCache GenerateRenderPackages()
return packages;
}

// This check is required as for some reason LibG fails to load, geometry nodes are null
// and we must return immediately before proceeding with further calls to ProtoGeometry
if (IsNodeNull(Node.CachedValue)) return packages;
// This check is required if for some reason LibG fails to load, geometry nodes are null
// and we must return immediately before proceeding with further calls to ProtoGeometry.

if (IsNodeNull(Node.CachedValue) || Node.CachedValue.IsFunction) return packages;

AssignInputNodes();

active = UpdatePosition();

if (!IsEnabled())
{
return packages;
}

// Blocking call to build render packages only in UI thread
// to avoid race condition with gizmo members b/w scheduler and UI threads.
// Race condition can occur if say one gizmo is moving due to another gizmo
Expand Down