don't initialize the direct manipulation extension when asm is not loaded #13219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjkkirschner
changed the title
pinzart90
approved these changes
Aug 15, 2022
There was a problem hiding this comment.
@mjkkirschner can we prevent loading the DM view extension altogether if ASM fails to preload? I think @QilongTang did this for the guided tour, if I'm not wrong.
aparajit-pratap
approved these changes
Aug 15, 2022
dont startup or call loaded on dm extension if asm not loaded
mjkkirschner
changed the title
|
thanks @aparajit-pratap for correcting my misunderstanding here - I attempted to resolve both suggestions you gave. |
|
tests passed on latest commit here: https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/6802/ |
| manipulatorDaemon = ManipulatorDaemon.Create(new NodeManipulatorFactoryLoader()); | ||
| } | ||
|
|
||
| public void Loaded(ViewLoadedParams viewLoadedParams) | ||
| { | ||
| if (!viewLoadedParams.StartupParams.IsGeometryLibraryLoaded) |
There was a problem hiding this comment.
Do we need the IsGeometryLibraryLoaded check in both Startup and Loaded functions?
There was a problem hiding this comment.
yes, I'd like to avoid partially initializing as much as possible.
aparajit-pratap
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Dynamo crashes when LibG is not loaded and a direct manipulator is created.
https://jira.autodesk.com/browse/DYN-5023
IsASMLoadedis false.IsASMLoadedis accurate in all situations, it seems to really only be set in CLI or sandbox startup - but thats probably sufficient since in-process hosts preload ASM themselves in most cases.I will send another PR with a test - want to get this in first.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fixed crash when node was moved which was going to create direct manipulator.
Reviewers