Visual Restyle Update #13133
Merged
Visual Restyle Update #13133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reduced margins and paddings to PackageTermsOfUse and UsageReportingAgreement dialogs
- added an icon set for dark and light theme for the maximize, minimize, close and restore buttons
- button resource named 'Normalize' changed to 'Restore' - all references to that resource have been renamed to match the new version - old icons replaced with new for the CloseButtonStyle, MinimizeButtonStyle, MaximizeButtonStyle, and RestoreButtonStyle - minor typo in one of the image resources fixed
- created a base button style to contain all the base properties of both Light and Dark theme styles - created a derived Dark theme style - changed the Edit Name dialog to use the new Dark Theme Style
- aligned light theme styles to also derive from the basebuttonstyle
- introduced ZoomDirectEditThreshold as a Configuration variable to control both Notes and Nodes rename zoom level
- fixed the mouseover and focus style for the HintingTextBox Style, which is used for the Edit Name (Node + Note) dialog
- added minimum height value for the Terms of Use dialog window
- added a minimum height to the scrollbar grip, so regardless of the amount of scrollable area, the decent grip height will be available
- change the color to the selected text when editing Node's name - added a new resource in the DynamoColorsAndBrushes dictionary file for future use
- changes to the Crash dialog window to make it resizable
- swapped the position of the 'Yes' and 'No' button so the blue 'continue' button is always at the right-hand side of the dialog
|
@dnenov would it be possible to please edit the PR submission and add in a description of what was improved? It helps with future referral when we look back :) |
- shifted the 'Cancel' button to the left-hand side of the dialog
- 'Up to date' text now fixed to the Dynamo logo when resizing the window
reddyashish
reviewed
Jul 28, 2022
|
Thanks @dnenov, Also can we delete the old images if no component is using it. |
- fixed an issue where renaming a Node directly would not mark the Graph as changed
- fixed issue where Graph wouldn't get marked as changed after editing a Note
- changed the shade of selection color for the Node to comply with contrast standards
- remove old png resources and replaced with new ones
reddyashish
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This is a follow-up PR to the Visual Restyle with a few minor tweaks, updates, and improvements.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@reddyashish
FYIs
@Amoursol