Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dnenov restyle visual restyle #13075

Merged
merged 23 commits into from
Jul 19, 2022

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Jun 29, 2022

Purpose

Visual restyle for dialog-type UI elements.

  • Dynamo Crash dialog
  • Agreement to Collect Usability Data on your use of Dynamo dialog
  • Graph Contains Unresolved Nodes and Cannot be Saved dialog
  • About Box dialog
  • Text edit dialog
  • Package Manager Terms of Use dialog

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

  • crash window restyle
  • agreement to collect usability data restyle
  • about box restyle
  • node name edit restyle; added inline rename when close-up (zoomed-in)
  • (package manager) terms of use restyle

Reviewers

@reddyashish

FYIs

@Amoursol

dnenov added 12 commits May 25, 2022 15:52
- part of the overall visual restyle in Q3 2022
- style matched to the existing DynamoMessageBox
- interim commit
- swapped window icons
- restyle Edit text pop-up window
- restyle to the Dynamo About window
- changed Edit Node to dark theme as per Figma
- small tweaks to UI of Edit, About and TermsOfUse Windows
- visual update to the Usage Reporting Agreement Window
- changed the fontsize for all RichTextFiles (this is a limitation)
- restyle to Dynamo crash window
- the Generic Task Dialog is the base class that is used to display the 'Graph Contains Unresolved Nodes and Cannot be Saved dialog.' Restyled to match the new Theme.
-contextually rename Node directly when under the ZoomThreshold
- small visual fix to the About Dialog
- added documentation for the new methods incorporated in the NodeView
@Amoursol
Copy link
Contributor

@Jingyi-Wen as per the Slack conversation, could you please update the two nodal graphics here? One sad face and the other band-aid face ones! 😁

- Graph contains unresolved nodes dialog: - blue button, image change
- Dynamo has crashed - image change
- About Dynamo - Dynamo icon text needs to be changed to darker color. Same for version text
@reddyashish
Copy link
Contributor

reddyashish commented Jul 12, 2022

@dnenov Will the crash dialog and unresolved nodes dialog have a black theme like the other dialogs Saw the latest changes.

dnenov added 6 commits July 12, 2022 14:39
- removed png files that are no longer needed
- multiple dialog texts have been updated
  - crash dialog
  - unresolved nodes
- minor alignment to control buttons of dialogs
- updated 'About' dialog following team meeting
- green color of (Up-to-date) changed
- (Up-to-date) changed to (Up to date)
- the dialog is now resizable with grip (slow performance noted, not sure how to optimize or if it is possible)
- minimize, maximize buttons added
- implemented a version of the high-density design style - generally less margins all around
- added the ability to close down a dialog window by hitting the Escape key
- fixed the style of the text box displaying the details of a crash, if expanded
- a new style created, old style is still in use so remains unchanged
@dnenov
Copy link
Collaborator Author

dnenov commented Jul 18, 2022

The unification of all the dialog icons (minimize, maximize, close, normalize) will be done in a separate PR.

@reddyashish reddyashish marked this pull request as ready for review July 18, 2022 18:20
dnenov added 2 commits July 18, 2022 20:14
- fixed the double 'Dynamo' text of the Crash Dialog Title inside the US Recourses
@reddyashish reddyashish marked this pull request as draft July 19, 2022 06:19
- causing a crash when opening Custom Nodes
@reddyashish reddyashish marked this pull request as ready for review July 19, 2022 11:27
- introducing a TextBox to allow for inline rename was causing a test to fail
@reddyashish
Copy link
Contributor

Thanks Deyan for fixing the regressions. Running the job again to make sure everything is passing.

@reddyashish
Copy link
Contributor

@reddyashish reddyashish merged commit c88bbf8 into DynamoDS:master Jul 19, 2022
@dnenov dnenov mentioned this pull request Jul 25, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants