Dyn 4843 watch node smaller

[jesusalvino]

Purpose

• Set the minimum height to the Watch Node when is created.
• Set the proper heights to the Watch Nodes when a Dynamo file is opened: The minimum height when is a single line, otherwise the Default height.

Declarations

Check these if you believe they are true

• The codebase is in a better state after this PR
• Is documented according to the standards
• The level of testing this PR includes is appropriate
• User facing strings, if any, are extracted into *.resx files
• All tests pass using the self-service CI.
• Snapshot of UI changes, if any.
• Changes to the API follow Semantic Versioning and are documented in the API Changes document.
• This PR modifies some build requirements and the readme is updated

###Reviewers
@QilongTang

###FYIs
@RobertGlobant20 @filipeotero

[jesusalvino]

[QilongTang]

FYI: @Amoursol @reddyashish Notes from standup, for single line of data, we should try to hide vertical scrollbar if possible

[jesusalvino]

Updating the added ACs

[QilongTang]

can we unsubscribe this somehow?

[jesusalvino]

Done

[QilongTang]

Looks good on my side. @Amoursol how is the new look?

[Amoursol]

Looks good on my side. @Amoursol how is the new look?

Looking much better for sure! Is it possible to also not have it quite as wide if we are returning a smaller digit like a 2?

Also, @jesusalvino can you please make a quick GIF of also showcasing the following:

small = 2; long = 10000; list = 0..20; doubleList = [0..20,20..40]; longSingle = Line.ByStartPointEndPoint( Point.ByCoordinates(10,20,30), Point.ByCoordinates(40,50,60));

WatchNodeTesting.mov

This will allow us to test a range of cases, and see how the node behaves.

[jesusalvino]

Looks good on my side. @Amoursol how is the new look?

Looking much better for sure! Is it possible to also not have it quite as wide if we are returning a smaller digit like a 2?

Also, @jesusalvino can you please make a quick GIF of also showcasing the following:

small = 2; long = 10000; list = 0..20; doubleList = [0..20,20..40]; longSingle = Line.ByStartPointEndPoint( Point.ByCoordinates(10,20,30), Point.ByCoordinates(40,50,60));
WatchNodeTesting.mov

This will allow us to test a range of cases, and see how the node behaves.

Done @Amoursol , notice the default width is 200, it turns dynamic according to the source

[reddyashish]

@jesusalvino @Amoursol @QilongTang What do you think about setting a maximum width and having a horizontal scroll bar. The last case seems pretty wide.

[reddyashish]

Looks good to me once we confirm the max width case.

[QilongTang]

Please confirm @Amoursol I also think the last case is too wide to display

[Amoursol]

@jesusalvino @Amoursol @QilongTang What do you think about setting a maximum width and having a horizontal scroll bar. The last case seems pretty wide.

Agreed, it sounded good on paper but looks a bit wild in practice! Can we please go with a width that is reasonable, then the user can expand again?

Worth testing = 2x the width of the watch node in 2.14 as a max stretch default.

[jesusalvino]

@Amoursol The max width of a Watch node will be its default 2X = 400, if the line exceeds it, the horizontal scrollbar will be available for the user

[Amoursol]

@Amoursol The max width of a Watch node will be its default 2X = 400, if the line exceeds it, the horizontal scrollbar will be available for the user

This is looking AWESOME! Thank you @jesusalvino. Did you manage to have it not as wide when returning a small number such as 2 alone?

[jesusalvino]

@Amoursol The max width of a Watch node will be its default 2X = 400, if the line exceeds it, the horizontal scrollbar will be available for the user

This is looking AWESOME! Thank you @jesusalvino. Did you manage to have it not as wide when returning a small number such as 2 alone?

yes

[Amoursol]

@Amoursol The max width of a Watch node will be its default 2X = 400, if the line exceeds it, the horizontal scrollbar will be available for the user

This is looking AWESOME! Thank you @jesusalvino. Did you manage to have it not as wide when returning a small number such as 2 alone?

yes

Looks perfect to me - thank you! Consider it done from my side 😊