Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix location show form owner inside uninstall package #12655

Merged
merged 3 commits into from
Feb 25, 2022

Conversation

chuongmep
Copy link
Contributor

@chuongmep chuongmep commented Feb 25, 2022

Purpose

this is a problem same with #12540, Fix location show message form uninstall package.
Before :
DynamoSandbox_Rf1C3QTSWj
After fixed

fuX7PE7Snj

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Always initialize uninstall package dialog with the right owner window

Reviewers

@QilongTang

FYIs

@QilongTang
Copy link
Contributor

@QilongTang
Copy link
Contributor

  1. Failed : DynamoCoreWpfTests.PackageManagerUITests.PackageManagerUninstallCommand
    Expected: ScheduledForUnload
    But was: None
    at NUnit.Framework.Assert.That(Object actual, IResolveConstraint expression, String message, Object[] args)
    at DynamoCoreWpfTests.PackageManagerUITests.PackageManagerUninstallCommand() in E:\Builds\chuongmep_Dynamo\owner_deletepackage\Dynamo\test\DynamoCoreWpfTests\PackageManagerUITests.cs:line 840

@QilongTang
Copy link
Contributor

@chuongmep Fixed test for you

@QilongTang QilongTang added this to the 2.14.0 milestone Feb 25, 2022
@QilongTang QilongTang merged commit e504beb into DynamoDS:master Feb 25, 2022
@QilongTang
Copy link
Contributor

@chuongmep
Copy link
Contributor Author

@chuongmep FYI:https://github.com/DynamoDS/Dynamo/wiki/Writing-Unit-Test-Libraries-for-Dynamo
Many thanks @QilongTang help me add test, may be I will down to VS2019 because NUnit 2 Test Adapter not yet in VS2022

@chuongmep chuongmep deleted the owner_deletepackage branch March 3, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants