Fix location show form owner inside Search for packages #12540
Conversation
chuongmep
changed the title
|
Brilliant addition @chuongmep - thank you very much for this 😁 |
|
Hi @chuongmep - there are some failing tests. |
@mjkkirschner May be it a problem other, this is when i check the existing code on the branch |
|
Hi @chuongmep - you can read some of the docs here, though they are a bit out of date, you need to set your test runtime engine version to x64 from the test menu. |
|
hi @chuongmep any reason why you closed this PR? I think these are still valid improvements, Let me know if I can help you with this |
|
@QilongTang I can't complete Testing NUnit 2 Test Adapter from report of @mjkkirschner in my computer with VS 2022, so I had closed this, if team can do that, let open again, thanks you ! |
|
Hi
You can install nunit test adapter nuget package instead of extension - or use nunit gui
… On Feb 22, 2022, at 10:15 PM, Chuong Ho ***@***.***> wrote:
@QilongTang I can't complete Testing NUnit 2 Test Adapter from report of @mjkkirschner in my computer with VS 2022, so I had closed this, if team can do that, let open again, thanks you !
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.
|
This reverts commit 263f9f8.
| @@ -675,7 +677,7 @@ internal async void ExecutePackageDownload(string name, PackageVersion package, | |||
| String.Format(Resources.MessageConfirmToInstallPackage, name, package.version) : | |||
| String.Format(Resources.MessageConfirmToInstallPackageToFolder, name, package.version, installPath); | |||
|
|
|||
| var result = MessageBoxService.Show(msg, | |||
| var result = MessageBoxService.Show(Owner,msg, | |||
There was a problem hiding this comment.
I find out that adding the owner here would break those 8 tests. Here is the error message, @pinzart Can you help us since you added those tests? Do we need to modify the tests based on these changes?
There was a problem hiding this comment.
We probably need to match the new function signatures
The failing tests just need to update the expected MessageBox signatures to include the Window argument
ex:
from: m.Show(It.IsAny < string > (), It.IsAny<string>(), It.IsAny<MessageBoxButton>())
to: m.Show(It.IsAny < Window >(), It.IsAny<string>(), It.IsAny<string>(), It.IsAny<MessageBoxButton>())
There was a problem hiding this comment.
Thank you @pinzart I will give that a try
|
All tests fixed locally and waiting for verification from https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/932/ |
|
Nice to see this done, thanks a lot. |
Purpose
Fix location show form oner inside package search form.Display appears very annoying when using two or more monitors
Before :
When we use one or two display , it not show center to check , it can show form to other screen
After fix :
Form show center owner of package manager for user.
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@QilongTang
FYIs
@Amoursol