Make IntegerSlider the only AKA for migration #11360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two classes that were declaring an 'AlsoKnownAs' attribute for 'DSCoreNodesUI.Input.IntegerSlider' in 'CoreNodeModels.Input': 'IntegerSlider' and 'IntegerSlider64Bit'. Since the latter obsoletes the former, it should be the only one declaring an 'AlsoKnownAs' attribute. Note that currently both are trying to be registered, which results in only one of them being registered but not really making any guarantees of which one it is. This also generate an exception catched internally but showed in the console.
|
@mmisol could you share a reproducible case? I suspect you see an exception when you try to open a legacy graph using the |
mmisol
changed the title
|
After discussing with @aparajit-pratap and seeing the migration from XML to |
aparajit-pratap
approved these changes
Dec 14, 2020
QilongTang
approved these changes
Dec 14, 2020
QilongTang
pushed a commit
that referenced
this pull request
Jan 27, 2021
There were two classes that were declaring an 'AlsoKnownAs' attribute for 'DSCoreNodesUI.Input.IntegerSlider' in 'CoreNodeModels.Input': 'IntegerSlider' and 'IntegerSlider64Bit'. While the latter obsoletes the former, it is not possible to migrate to it from XML, so only 'IntegerSlider' should continue declaring an 'AlsoKnownAs' attribute. Note that currently both classes are trying to be registered, which results in only one of them being registered but not really making any guarantees of which one it is. This also generates an exception catched internally but shown in the console.
QilongTang
added a commit
that referenced
this pull request
Jan 28, 2021
* Dock and Undock view extension with Dynamic extension ID as edge case (#11394) * Initial Commit with settings null check * Add unit test * Add view extension loading warning * Update message * Initial Commit (#11366) * Do not aggregate node execution analytics anymore (#11356) * Do not aggregate node execution analytics anymore * Update to use new event combo * Update Comments * Make IntegerSlider the only AKA for migration (#11360) There were two classes that were declaring an 'AlsoKnownAs' attribute for 'DSCoreNodesUI.Input.IntegerSlider' in 'CoreNodeModels.Input': 'IntegerSlider' and 'IntegerSlider64Bit'. While the latter obsoletes the former, it is not possible to migrate to it from XML, so only 'IntegerSlider' should continue declaring an 'AlsoKnownAs' attribute. Note that currently both classes are trying to be registered, which results in only one of them being registered but not really making any guarantees of which one it is. This also generates an exception catched internally but shown in the console. * Revised icons for AnyTrue and AnyFalse nodes (#11361) * Implement ToString for DS Dictionary (#11358) This is done to provide meaningful output when a dictionary is provided to nodes like 'String from Array' and 'String from Object'. These nodes call built-in DS functions that end up calling ToString on the dictionary, which until now used the default implementation inherited from Object which just returned the class name. Co-authored-by: Martin Misol Monzo <[email protected]> Co-authored-by: Laurence Elsdon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
There were two classes that were declaring an 'AlsoKnownAs' attribute
for 'DSCoreNodesUI.Input.IntegerSlider' in 'CoreNodeModels.Input':
'IntegerSlider' and 'IntegerSlider64Bit'. While the latter obsoletes
the former, it is not possible to migrate to it from XML, so only
'IntegerSlider' should continue declaring an 'AlsoKnownAs' attribute.
Note that currently both classes are trying to be registered, which
results in only one of them being registered but not really making any
guarantees of which one it is. This also generates an exception catched
internally but shown in the console.
Declarations
Check these if you believe they are true
*.resxfiles