-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow integer slider to support 64 bit ints #10972
Allow integer slider to support 64 bit ints #10972
Conversation
@aparajit-pratap an interesting set of failures, including the ones your predicted. |
return BuildIntNode(Convert.ToInt32(value)); | ||
case "UInt64": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use nameof
?
I guess with c# 7 we should be doing:
https://stackoverflow.com/a/4478490
@aparajit-pratap I would try look at when outport model constructor got called when placing integer slider: https://github.com/DynamoDS/Dynamo/blob/master/src/DynamoCore/Graph/Nodes/PortModel.cs#L335 |
Thanks @QilongTang! |
@aparajit-pratap Seems there are regressions with this PR? |
@QilongTang there are 2 regressions remaining. I addressed many of them yesterday. Will address the remaining ones today. In the meantime do you have any comments on the rest of the review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks solid, just a few minor comments!
Purpose
https://jira.autodesk.com/browse/DYN-1085
IntegerSlider64Bit
that derives fromSliderBase<long>
to support 64 bit integersCoreNodeModels.Input.IntegerSlider
type from JSON as aCoreNodeModels.Input.IntegerSlider64Bit
so that the new 64 bit slider node is instantiatedCoreNodeModels.Input.IntegerSlider
type so that new DYN's can be opened by older versions of DynamoDeserialize 32 bit integer slider from old XML format as new 64 bit integer slider- This does not seem to be straightforward since in order to not break the API I needed to keep the legacy class, which is why I had to retain the legacy behaviour of xml-based 32 bit integer sliders (to be deserialized as 32 bit). Now only when you save the XML file (when saved as JSON) and reopened, will the slider behave as a 64 bit integer slider node, not before.Declarations
Check these if you believe they are true
*.resx
filesReviewers
@DynamoDS/dynamo