Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve description of equal numbers node #11123

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

mmisol
Copy link
Collaborator

@mmisol mmisol commented Sep 16, 2020

Purpose

The summary is changed to reflect the fact that it works with numbers
only. Also the port names are declared on the node class to make them
appear in the library.

Looks like this now:

Screen Shot 2020-09-16 at 4 33 37 PM

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@QilongTang @zeusongit

FYIs

@Amoursol

The summary is changed to reflect the fact that it works with numbers
only. Also the port names are declared on the node class to make them
appear in the library.
@Amoursol
Copy link
Contributor

LGTM @mmisol !

@mmisol mmisol merged commit e60306d into DynamoDS:master Sep 16, 2020
@QilongTang
Copy link
Contributor

Nice!

@QilongTang QilongTang added this to the 2.9.0 milestone Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants