Skip to content

Commit

Permalink
Improve description of equal numbers node (#11123)
Browse files Browse the repository at this point in the history
The summary is changed to reflect the fact that it works with numbers
only. Also the port names are declared on the node class to make them
appear in the library.
  • Loading branch information
mmisol authored Sep 16, 2020
1 parent 7b098a9 commit e60306d
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/Libraries/CoreNodeModels/Equals.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
using Dynamo.Graph.Nodes;
using Newtonsoft.Json;
using ProtoCore.AST.AssociativeAST;
using ProtoCore.DSASM;
using ProtoCore.Utils;

namespace CoreNodeModels
Expand All @@ -14,6 +13,7 @@ namespace CoreNodeModels
[NodeDescription("EqualsWithToleranceDescription", typeof(Resources))]
[NodeCategory("Core.Math")]
[NodeSearchTags("EqualsWithToleranceSearchTags", typeof(Resources))]
[InPortNames("x", "y", "tolerance")]
[InPortTypes("double", "double", "double")]
[OutPortTypes("bool")]
[IsDesignScriptCompatible]
Expand Down
4 changes: 2 additions & 2 deletions src/Libraries/CoreNodeModels/Properties/Resources.Designer.cs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,7 @@
<value>color</value>
</data>
<data name="EqualsWithToleranceDescription" xml:space="preserve">
<value>Equals with tolerance input.</value>
<value>Compares if two numbers are equal given a certain tolerance.</value>
<comment>Description for Equals with tolerance node</comment>
</data>
<data name="EqualsWithToleranceLhsRhsTooltip" xml:space="preserve">
Expand Down
2 changes: 1 addition & 1 deletion src/Libraries/CoreNodeModels/Properties/Resources.resx
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,7 @@
<value>color</value>
</data>
<data name="EqualsWithToleranceDescription" xml:space="preserve">
<value>Equals with tolerance input.</value>
<value>Compares if two numbers are equal given a certain tolerance.</value>
<comment>Description for Equals with tolerance node</comment>
</data>
<data name="EqualsWithToleranceLhsRhsTooltip" xml:space="preserve">
Expand Down

0 comments on commit e60306d

Please sign in to comment.