Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick: print in Python + fix #11013

Merged
merged 2 commits into from
Aug 17, 2020
Merged

Cherry pick: print in Python + fix #11013

merged 2 commits into from
Aug 17, 2020

Conversation

mmisol
Copy link
Collaborator

@mmisol mmisol commented Aug 17, 2020

Purpose

Include changes from #11000 and #11007 in 2.8

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

SHKnudsen and others added 2 commits August 17, 2020 13:49
@SHKnudsen @mmisol
Redirect python print to Dynamo console (DynamoDS#11000)
bc1639f 
* redirect print to DynamoConsol + update unit test

* comment updates

* Update CPythonEvaluator.cs
@mmisol
Move Python print function to local scope (DynamoDS#11007)
e832160 
This fixes build issues that appeared after merging 'print' function
changes for CPython3. Those changes moved the print function to the
globalScope which caused the 'DynamoPrintLogsToConsole' test to fail.
The reason for this is that Python unit tests, which don't use a model,
still initialize the globalScope but do not provide a logger, making
later logging tests fail.
@mmisol mmisol added this to the 2.8 milestone Aug 17, 2020
@mmisol mmisol merged commit f845916 into DynamoDS:RC2.8.0_master Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mmisol @SHKnudsen