Redirect python print to Dynamo console #11000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmisol
reviewed
Aug 14, 2020
There was a problem hiding this comment.
Looks pretty good. Only an issue with escaping ' and a couple of typos.
About Iron Python, you are correct @SHKnudsen , there is no such thing as a global scope, so your solution looks fine.
|
|
||
| int amt = Math.Min(bindingNames.Count, bindingValues.Count); | ||
|
|
||
| for (int i = 0; i < amt; i++) | ||
| { | ||
| scope.Set((string)bindingNames[i], InputMarshaler.Marshal(bindingValues[i]).ToPython()); | ||
| } | ||
|
|
||
| scope.Exec($"sys.stdout.prefix = '{nodeName}'"); |
There was a problem hiding this comment.
I guess this code could run into problems when nodeName contains a ' character. Could you escape it and maybe and an ' to a node name in the test so that we are covering it?
There was a problem hiding this comment.
i added the nodename as a variable to the PyScope, that seems to work better and works with all special characters.
mmisol
approved these changes
Aug 14, 2020
|
Thanks @SHKnudsen ! I will just wait for the tests to run and merge this in. |
mmisol
pushed a commit
to mmisol/Dynamo
that referenced
this pull request
Aug 17, 2020
* redirect print to DynamoConsol + update unit test * comment updates * Update CPythonEvaluator.cs
8 tasks
mmisol
added a commit
that referenced
this pull request
Aug 17, 2020
* Redirect python print to Dynamo console (#11000) * redirect print to DynamoConsol + update unit test * comment updates * Update CPythonEvaluator.cs * Move Python print function to local scope (#11007) This fixes build issues that appeared after merging 'print' function changes for CPython3. Those changes moved the print function to the globalScope which caused the 'DynamoPrintLogsToConsole' test to fail. The reason for this is that Python unit tests, which don't use a model, still initialize the globalScope but do not provide a logger, making later logging tests fail. Co-authored-by: Sylvester Knudsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR builds on the work of https://jira.autodesk.com/browse/DYN-2971, to add functionality to redirect Python
printto the Dynamo console. It also removes the currentDynamoPrint()function.Declarations
Check these if you believe they are true
*.resxfilesReviewers
@mmisol
FYIs
@mjkkirschner
@QilongTang
FYI @mmisol seems like the IronPythonEvaluator does not have a global scope, is that correctly understood? For redirecting prints in IronPython i simply
ProcessAdditionalBindingsin the local scope. Let me know if you are okay with that.