Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DYN-2757] Added system.collections.immutable dependency to DynamoVisualProgramming.Core nuget package #10778

Merged
merged 4 commits into from
Jun 18, 2020
Merged

[DYN-2757] Added system.collections.immutable dependency to DynamoVisualProgramming.Core nuget package #10778

merged 4 commits into from
Jun 18, 2020

Conversation

zeusongit
Copy link
Contributor

@zeusongit zeusongit commented Jun 17, 2020 •
edited
Loading

Purpose

DesignScriptBuiltin.dll contains our dictionary type which is implemented using immutable dictionaries, but we have not marked that as a nuget dependency of our package, therefore this PR is adding that as the dependency.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.

Reviewers

@DynamoDS/dynamo

@zeusongit zeusongit added the WIP label Jun 17, 2020
@zeusongit zeusongit changed the title [WIP] Update DynamoVisualProgramming.Core.nuspec [DYN-2757] Added system.collections.immutable dependency to DynamoVisualProgramming.Core nuget package Jun 18, 2020
@zeusongit zeusongit requested a review from mjkkirschner June 18, 2020 00:59
@zeusongit zeusongit removed the WIP label Jun 18, 2020
@aparajit-pratap
Copy link
Contributor

Thanks for updating the Readme.

QilongTang
QilongTang approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Thank you for fixing the readme! Did you had a chance to build it locally and use Nuget explorer to check the result package?

@zeusongit zeusongit merged commit 315c246 into DynamoDS:master Jun 18, 2020
zeusongit added a commit to zeusongit/Dynamo that referenced this pull request Jun 24, 2020
@zeusongit @Zeus1717
Cherry pick DynamoDS#10778 into 2.7
2685e3a
@zeusongit zeusongit mentioned this pull request Jun 24, 2020
Merged
QilongTang pushed a commit that referenced this pull request Jun 24, 2020
@zeusongit
Cherry pick #10778 into 2.7 (#10804)
f2a759f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aparajit-pratap aparajit-pratap aparajit-pratap left review comments

@QilongTang QilongTang QilongTang approved these changes

@mjkkirschner mjkkirschner Awaiting requested review from mjkkirschner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zeusongit @aparajit-pratap @QilongTang @Zeus1717