Skip to content

Commit

Permalink
[DYN-2757] Added system.collections.immutable dependency to DynamoVis…
Browse files Browse the repository at this point in the history
…ualProgramming.Core nuget package (#10778)

* Update DynamoVisualProgramming.Core.nuspec

* Update README.md

* Correct indentation
  • Loading branch information
zeusongit authored Jun 18, 2020
1 parent 9cafe8a commit 315c246
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 10 deletions.
26 changes: 17 additions & 9 deletions tools/NuGet/README.md
Original file line number Diff line number Diff line change
@@ -1,27 +1,35 @@
## About ##
# About

This folder contains scripts to build and publish the DynamoVisualProgramming NuGet packages into NuGet Gallery and Autodesk Artifactory.

## Instructions ##
## Instructions

To build NuGet packages locally, run BuildPackages.bat with parameters.

```
```bash
.\BuildPackages.bat param1 param2(optional)
```

param1 should be where the nuspec path
*param1* should be the path where the nuspec files exist

param2 should be where the dynamo binaries path(optional, if it is not provided, it falls back to the `harvest` folder assuming dev has run the Install.sln)
*param2* should be the path where the dynamo binaries exist(optional, if it is not provided, it falls back to the `harvest` folder assuming dev has run the Install.sln)

see example
See Example:

```bash
.\BuildPackages.bat "template-artifactory" "...\GitHub\Dynamo\src\DynamoInstall\harvest"
```
.\BuildPackages.bat 'template-artifactory' '...\GitHub\Dynamo\src\DynamoInstall\harvest'
```

> Note: To build Install.sln solution you will need wix installed.
This command will wrap the dlls in the `harvest` folder into `nupkg` files and put them in current folder.

Alternatively, you can provide the second parameter as the path to your Dynamo binaries built with Release configuration, such as:

```bash
.\BuildPackages.bat "template-artifactory" "...\GitHub\Dynamo\bin\AnyCPU\Release"
```
The version is parameterized in the nuspec file and the parameter is set to the version number obtained in the `BuildPackages.bat` file. This is done using a `-properties` option while using the `nuget pack` command. The nuspecs from the original folders namely, `template-nuget` and `template-artifactory`. These are passed as command line arguments (which is what the %1 is) while invoking the `BuildPackages.bat` script from the `PostNuGetPackages.bat` and the `PostArtifactoryPackages.bat` files respectively.

To post them as pre-release packages into NuGet Gallery and Artifactory, skip the above step and run BuildAndPostPackages.bat.
To post them as pre-release packages into NuGet Gallery and Artifactory, skip the above step and run PostNugetPackages.bat or PostArtifactoryPackages.bat.
Supply the NuGet Gallery API Key as the first parameter and the Artifactory API Key as the second parameter for this batch file.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0"?>
<package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
<metadata>
<metadata>
<id>DynamoVisualProgramming.Core</id>
<version>$Version$</version>
<authors>Autodesk</authors>
Expand All @@ -27,6 +27,7 @@
<dependency id="NUnit" version="2.6.3"/>
<dependency id="DynamoVisualProgramming.ZeroTouchLibrary" version="$Version$"/>
<dependency id="Newtonsoft.Json" version="8.0.3"/>
<dependency id="System.Collections.Immutable" version="1.7.1"/>
</group>
</dependencies>
</metadata>
Expand Down

0 comments on commit 315c246

Please sign in to comment.