-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add point and line shaders #10709
Merged
Merged
Add point and line shaders #10709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aparajit-pratap
commented
May 28, 2020
update helix common shader files to 2.11 update our pointshader to use geometry stage in beteen vertex and pixel stage like helix shader
update shaders use the blendFactor prop on pointGeometry to pack our data material classes are not used
find same buffer slot for lines and points yay refactor shared data core update tests
work in progress for review
aparajit-pratap
changed the title
[WIP] Add point and line shaders
Add point and line shaders
Jun 3, 2020
mjkkirschner
reviewed
Jun 3, 2020
mjkkirschner
reviewed
Jun 3, 2020
mjkkirschner
reviewed
Jun 3, 2020
@aparajit-pratap this looks great! - Much simpler than before! |
|
mjkkirschner
reviewed
Jun 3, 2020
mjkkirschner
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
DYN-2702, DYN-2707
This PR includes the following changes:
FadingNearDistance
property on the helix builtinPointMaterialCore
andLineMaterialCore
types to pass state data to the shaderDynamoPointLineRenderCore
class for bothDynamoPointGeometryModel3D
andDynamoLineGeometryModel3D
to override the required helixRenderCore
classDynamoRenderCoreDataStore
class to manage state information for all geometry types - mesh, point and lineDeclarations
Check these if you believe they are true
*.resx
filesReviewers
@mjkkirschner
@DynamoDS/dynamo