Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add point and line shaders #10709

Merged
merged 19 commits into from
Jun 4, 2020
Merged

Conversation

aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented May 28, 2020

Purpose

DYN-2702, DYN-2707

This PR includes the following changes:

  1. Replaced assignment of colors for the different states (selection, isolation, frozen, etc.) to points and lines with shaders
  2. Added 3 new shaders - pixel shader each for point and line and one common vertex shader for both
  3. Enabled line/curve geometry selection
  4. Added the default helix geometry shader pass for both point and line rendering
  5. Using the FadingNearDistance property on the helix builtin PointMaterialCore and LineMaterialCore types to pass state data to the shader
  6. Added new common DynamoPointLineRenderCore class for both DynamoPointGeometryModel3D and DynamoLineGeometryModel3D to override the required helix RenderCore class
  7. Added common DynamoRenderCoreDataStore class to manage state information for all geometry types - mesh, point and line
  8. Updated local copy of common helix shaders used by our shaders from helix-toolkit version 2.11
  9. Updated image comparison baselines images for points, lines
  10. Deleted WPF visualization tests related to point and line vertex colors that are no longer relevant

Point_line_shader

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.

Reviewers

@mjkkirschner
@DynamoDS/dynamo

mjkkirschner and others added 10 commits May 29, 2020 16:08
update helix common shader files to 2.11
update our pointshader to use geometry stage in beteen vertex and pixel stage like helix shader
update shaders
use the blendFactor prop on pointGeometry to pack our data
material classes are not used
find same buffer slot for lines and points yay
refactor
shared data core
update tests
@aparajit-pratap aparajit-pratap changed the title [WIP] Add point and line shaders Add point and line shaders Jun 3, 2020
@aparajit-pratap aparajit-pratap added the PTAL Please Take A Look 👀 label Jun 3, 2020
@mjkkirschner
Copy link
Member

@aparajit-pratap this looks great! - Much simpler than before!
Did you need to update those image tests?

@aparajit-pratap
Copy link
Contributor Author

aparajit-pratap commented Jun 3, 2020

@aparajit-pratap this looks great! - Much simpler than before!
Did you need to update those image tests?

I found that I need to update just 2 of them. Found only those 2 to be failing. I am double-checking.

@aparajit-pratap aparajit-pratap merged commit 02df36c into DynamoDS:master Jun 4, 2020
@aparajit-pratap aparajit-pratap deleted the dyn-2702 branch June 4, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PTAL Please Take A Look 👀
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants