Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide/Show (Un)Deprecate Button for package owner only #10091

Merged
merged 6 commits into from
Oct 31, 2019
Merged

Hide/Show (Un)Deprecate Button for package owner only #10091

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cad973a
Edited candeprecate method to check author before activation deprecat…
zeusongit Oct 25, 2019
a7371ac
removed unnecessary comments
zeusongit Oct 25, 2019
9c4a35b
Applied same logic as can deprecate to can undeprecate
zeusongit Oct 25, 2019
9b3ce0c
Update PackageViewModel.cs
zeusongit Oct 25, 2019
dfbb2a9
packagemanager specific function bubbled up in packagemanagerclient c…
zeusongit Oct 29, 2019
732a412
positive test added
zeusongit Oct 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions src/DynamoCoreWpf/ViewModels/PackageManager/PackageViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,16 @@ private void Deprecate()

private bool CanDeprecate()
{
return dynamoViewModel.Model.AuthenticationManager.HasAuthProvider;
PackageInfo pkg = new PackageInfo(Model.Name, new Version(Model.VersionName));
bool isAuthor = false;
var header = packageManagerClient.GetPackageHeader(pkg);
if (header != null) {
if (header.maintainers.First().username.Equals(dynamoViewModel.Model.AuthenticationManager.Username))
QilongTang marked this conversation as resolved.
Show resolved Hide resolved
{
isAuthor = true;
}
}
return dynamoViewModel.Model.AuthenticationManager.HasAuthProvider && isAuthor;
zeusongit marked this conversation as resolved.
Show resolved Hide resolved
}

private void Undeprecate()
Expand All @@ -203,13 +212,22 @@ private void Undeprecate()
Resources.UndeprecatingPackageMessageBoxTitle,
MessageBoxButton.YesNo, MessageBoxImage.Question);
if (res == MessageBoxResult.No) return;

packageManagerClient.Undeprecate(Model.Name);
}

private bool CanUndeprecate()
{
return dynamoViewModel.Model.AuthenticationManager.HasAuthProvider;
PackageInfo pkg = new PackageInfo(Model.Name, new Version(Model.VersionName));
zeusongit marked this conversation as resolved.
Show resolved Hide resolved
bool isAuthor = false;
var header = packageManagerClient.GetPackageHeader(pkg);
if (header != null)
{
if (header.maintainers.First().username.Equals(dynamoViewModel.Model.AuthenticationManager.Username))
{
isAuthor = true;
}
}
return dynamoViewModel.Model.AuthenticationManager.HasAuthProvider && isAuthor;
zeusongit marked this conversation as resolved.
Show resolved Hide resolved
}

private void PublishNewPackageVersion()
Expand Down